From: Francesco Dolcini <francesco@dolcini.it>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Amitkumar Karwar <amitkumar.karwar@nxp.com>,
Neeraj Kale <neeraj.sanjaykale@nxp.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] Bluetooth: btnxpuart: remove useless assignment
Date: Tue, 28 Nov 2023 08:31:07 +0100 [thread overview]
Message-ID: <ZWWXOxl6XZJs2reN@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <f19ac2b9-7e4c-44e8-b979-c8c4e9d627ab@kernel.org>
On Tue, Nov 28, 2023 at 06:26:56AM +0100, Jiri Slaby wrote:
> On 27. 11. 23, 20:14, Francesco Dolcini wrote:
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> >
> > Remove useless assignment of rx_skb to NULL in case the skb is in error,
> > this is already done in h4_recv_buf() that is executed a few lines
> > before.
>
> In case of error, nxpdev->rx_skb contains the error, not NULL, right?
correct.
The point is that we have
if (IS_ERR(skb))
skb = NULL;
at the beginning of h4_recv_buf(), that is called a few lines before,
making the assignment in btnxpuart.c redundant.
Francesco
next prev parent reply other threads:[~2023-11-28 7:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 19:14 [PATCH v1 0/3] Bluetooth: fix recv_buf() return value Francesco Dolcini
2023-11-27 19:14 ` [PATCH v1 1/3] Bluetooth: btnxpuart: " Francesco Dolcini
2023-11-27 19:24 ` Greg KH
2023-11-28 5:23 ` Jiri Slaby
2023-11-28 7:40 ` Francesco Dolcini
2023-11-27 19:14 ` [PATCH v1 2/3] Bluetooth: btmtkuart: " Francesco Dolcini
2023-11-27 19:14 ` [PATCH v1 3/3] Bluetooth: btnxpuart: remove useless assignment Francesco Dolcini
2023-11-28 5:26 ` Jiri Slaby
2023-11-28 7:31 ` Francesco Dolcini [this message]
2023-11-27 19:23 ` [PATCH v1 0/3] Bluetooth: fix recv_buf() return value Francesco Dolcini
2023-11-28 5:17 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWWXOxl6XZJs2reN@francesco-nb.int.toradex.com \
--to=francesco@dolcini.it \
--cc=amitkumar.karwar@nxp.com \
--cc=francesco.dolcini@toradex.com \
--cc=jirislaby@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox