From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3AC5C07CA9 for ; Tue, 28 Nov 2023 10:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344075AbjK1KxV (ORCPT ); Tue, 28 Nov 2023 05:53:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344042AbjK1KxR (ORCPT ); Tue, 28 Nov 2023 05:53:17 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E965182; Tue, 28 Nov 2023 02:53:23 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40b399a6529so22920475e9.1; Tue, 28 Nov 2023 02:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701168802; x=1701773602; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=jHeRUHjNgcHkAoNUOrB2gZOKHhIEPCIVSV2fuslJNro=; b=RGAJf/G2Po5XSEGRT1DGAbV0DxzhtijBRa98A6qAJyfQt5Qi3dDkbuAQIrV6omSjT+ 1Ee8kx3XiZM+F+FcR9WukkVfuXw/PqcUXnE7Pv7UhMGsqA7KDTV1F+owebyfNg/Diab4 QkAPvirezS/iSOY0j287UDZydKjl3QJLwUd22AwMb3DMIlypBQc6yOJGrOWP99w/1qFO YTyiKRIXynoq1m0VSZM2mrieav6VH3RYGutWFoBVx+rRzp/2S0fSUS49GQB1qCInn+vd 0OZ4TPGV8yO2ExylpPRSS/Vkih7jGTFL75UmGfYkgcERTX8RNPgbFxFw8Ow5ztfPklyu kroQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701168802; x=1701773602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jHeRUHjNgcHkAoNUOrB2gZOKHhIEPCIVSV2fuslJNro=; b=cw1wef+vFgRtZMmdtn89Mq4bJBWp40G/b0rCn/MlvavttB/k/kpf9KxXOL4eBmAjP2 ajoXMpDPx3ScPS53kczsjsQqH7wsvwuW+aksXfdYT4cQKB/atRwVeNIBW8ipBPF/7FG3 KNkxsuvyhUrC6+y+yaToM06pfpLK6JqtLlfLTQiwrmZ7N5I1+zyAJv259gLZs7Cyqb06 +cmEAxtWKXEm57lxwSirB5iOMhFOYi+ufqTXKQWCuyGDq/8uhTi18AEzN5tlxKQr+2LK Ackom6pQeE6j+roaGixpuV2vVIn//7oy+EPgxCGzwkMvrRnM8lNo0ggA1eUNRXTXblKS I46Q== X-Gm-Message-State: AOJu0YzssKV8T0N93CuQqkenzP9QKwJ7AhGAl+tdLrPbnuedmsDFDCOs 2uS0zfCoT0R2JXPwm641Ito= X-Google-Smtp-Source: AGHT+IHAtXvi+k2SNzavvcAHSEfDOl1eBAxYx48aeh6/aYmJAhtMVGM/zG7vKgoWiQ3XVkMolR/AzQ== X-Received: by 2002:a5d:40cd:0:b0:333:224:48d with SMTP id b13-20020a5d40cd000000b003330224048dmr4670459wrq.33.1701168801641; Tue, 28 Nov 2023 02:53:21 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id d15-20020adff84f000000b00333097fc050sm2112498wrq.1.2023.11.28.02.53.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 02:53:21 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 28 Nov 2023 11:53:19 +0100 To: "Masami Hiramatsu (Google)" Cc: Alexei Starovoitov , Steven Rostedt , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Sven Schnelle , Alexei Starovoitov , Arnaldo Carvalho de Melo , Daniel Borkmann , Alan Maguire , Mark Rutland , Peter Zijlstra , Thomas Gleixner , Guo Ren Subject: Re: [PATCH v3 28/33] fprobe: Rewrite fprobe on function-graph tracer Message-ID: References: <170109317214.343914.4784420430328654397.stgit@devnote2> <170109352014.343914.17580314660854847955.stgit@devnote2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170109352014.343914.17580314660854847955.stgit@devnote2> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2023 at 10:58:40PM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Rewrite fprobe implementation on function-graph tracer. > Major API changes are: > - 'nr_maxactive' field is deprecated. > - This depends on CONFIG_DYNAMIC_FTRACE_WITH_ARGS or > !CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, and > CONFIG_HAVE_FUNCTION_GRAPH_FREGS. So currently works only > on x86_64. > - Currently the entry size is limited in 15 * sizeof(long). > - If there is too many fprobe exit handler set on the same > function, it will fail to probe. > > Signed-off-by: Masami Hiramatsu (Google) > --- > Changes in v3: > - Update for new reserve_data/retrieve_data API. > - Fix internal push/pop on fgraph data logic so that it can > correctly save/restore the returning fprobes. hi, looks like this one conflicts with recent: 4bbd93455659 kprobes: kretprobe scalability improvement jirka