From: Andy Shevchenko <andy@kernel.org>
To: Boerge Struempfel <boerge.struempfel@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
bstruempfel@ultratronik.de
Subject: Re: [PATCH v2] gpiolib: sysfs: Fix error handling on failed export
Date: Tue, 28 Nov 2023 18:29:10 +0200 [thread overview]
Message-ID: <ZWYVVvB0O-CBIbos@smile.fi.intel.com> (raw)
In-Reply-To: <20231128141321.51669-1-boerge.struempfel@gmail.com>
On Tue, Nov 28, 2023 at 03:13:21PM +0100, Boerge Struempfel wrote:
> If gpio_set_transitory() fails, we should free the gpio again. Most
gpio --> GPIO descriptor
(I already mentioned capitalization in v1 review)
> notably, the flag FLAG_REQUESTED has previously been set in
> gpiod_request_commit(), and should be reset on failure.
>
> To my knowledge, this does not affect any current users, since the
> gpio_set_transitory() mainly returns 0 and -ENOTSUPP, which is converted
> to 0. However the gpio_set_transitory() function calles the .set_config()
> function of the corresponding gpio chip and there are some gpio drivers in
gpio --> GPIO
> which some (unlikely) branches return other values like -EPROBE_DEFER,
> and EINVAL. In these cases, the above mentioned FLAG_REQUESTED would not
-EINVAL
> be reset, which results in the pin being blocked until the next reboot.
Fixes tag?
(`git log --no-merges --grep "Fixes:" will show you examples)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-28 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 14:13 [PATCH v2] gpiolib: sysfs: Fix error handling on failed export Boerge Struempfel
2023-11-28 16:29 ` Andy Shevchenko [this message]
2023-11-29 15:13 ` Börge Strümpfel
2023-11-29 16:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWYVVvB0O-CBIbos@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=boerge.struempfel@gmail.com \
--cc=brgl@bgdev.pl \
--cc=bstruempfel@ultratronik.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox