From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C8FC07CA9 for ; Tue, 28 Nov 2023 20:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345895AbjK1U3c (ORCPT ); Tue, 28 Nov 2023 15:29:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345805AbjK1U3W (ORCPT ); Tue, 28 Nov 2023 15:29:22 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D3151988 for ; Tue, 28 Nov 2023 12:29:28 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDED7C433C8; Tue, 28 Nov 2023 20:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701203368; bh=LZUDexNsDfHLTiZ4vVRpRhkkcAv3/p4UDi4s40i48v4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OhKeSxSO/+o1xVPh+tVwuB7lC0aY6qGjLmq8MfFmK6FOP6uqqFw7rQv6QJvQfn8fg Bwt9XF6Ohp8j0E0656s9FJM4udBDzPjufetxZD9cUL+o1M3/30QK48CIcRuxnCqVDG zTI/eu2XZtyWnYFmi9bbXafQIeXNNzKSDEZLRApPl9WZYgJPS2yB4xfE8h3f7+nwVq i3mn1qROrQqIG3yplMopoHS6dxOEy7v59xX39wQSmNi8wBodbgRg1nfxxgQAmoo3Fs zY+G8zm8UbLCFjilY/KzkvYhjG/dY6zSjyHDFfk0gm8N/E9Jd4zQazLFZauCCWrtfd dRISCTybmDIZA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 93DD540094; Tue, 28 Nov 2023 17:29:25 -0300 (-03) Date: Tue, 28 Nov 2023 17:29:25 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Nick Terrell , Kan Liang , Andi Kleen , Kajol Jain , Athira Rajeev , Huacai Chen , Masami Hiramatsu , Vincent Whitchurch , "Steinar H. Gunderson" , Liam Howlett , Miguel Ojeda , Colin Ian King , Dmitrii Dolgov <9erthalion6@gmail.com>, Yang Jihong , Ming Wang , James Clark , K Prateek Nayak , Sean Christopherson , Leo Yan , Ravi Bangoria , German Gomez , Changbin Du , Paolo Bonzini , Li Dong , Sandipan Das , liuwenyu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v4 04/53] perf mmap: Lazily initialize zstd streams Message-ID: References: <20231102175735.2272696-1-irogers@google.com> <20231102175735.2272696-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Nov 28, 2023 at 09:55:22AM -0800, Ian Rogers escreveu: > On Tue, Nov 28, 2023 at 9:38 AM Arnaldo Carvalho de Melo wrote: > > Em Tue, Nov 28, 2023 at 02:14:33PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Trying to fix this now: > > > > > > 6 20.59 alpine:3.18 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r10) > > > In file included from util/zstd.c:5: > > > /git/perf-6.6.0-rc1/tools/perf/util/compress.h:34:1: error: unknown type name 'ssize_t'; did you mean 'size_t'? > > So the problem was really the one above, that got fixed with the patch > > below, that is what 'man size_t' documents on my fedora:38 system. > Thanks, perhaps this is something clang-tidy, clang-format or similar > could help with in the future. There was event IWYU discussion at LPC: > https://lpc.events/event/17/contributions/1620/attachments/1228/2520/Linux%20Kernel%20Header%20Optimization.pdf Yeah, that is interesting, I took a quick look and it looks promising. I did this manually in various areas of the kernel and in tools/perf from time to time, to speed up the building process, etc. - Arnaldo