[PATCH v1 1/1] units: Add missing header

[PATCH v1 1/1] units: Add missing header

[Andy Shevchenko]

BITS_PER_BYTE is defined in bits.h.

Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/units.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/units.h b/include/linux/units.h
index ff1bd6b5f5b3..45110daaf8d3 100644
--- a/include/linux/units.h
+++ b/include/linux/units.h
@@ -2,6 +2,7 @@
 #ifndef _LINUX_UNITS_H
 #define _LINUX_UNITS_H
 
+#include <linux/bits.h>
 #include <linux/math.h>
 
 /* Metric prefixes in accordance with Système international (d'unités) */
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/1] units: Add missing header

[Randy Dunlap]

On 11/28/23 09:44, Andy Shevchenko wrote:
> BITS_PER_BYTE is defined in bits.h.
> 
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  include/linux/units.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/units.h b/include/linux/units.h
> index ff1bd6b5f5b3..45110daaf8d3 100644
> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_UNITS_H
>  #define _LINUX_UNITS_H
>  
> +#include <linux/bits.h>
>  #include <linux/math.h>
>  
>  /* Metric prefixes in accordance with Système international (d'unités) */

-- 
~Randy

Re: [PATCH v1 1/1] units: Add missing header

[Andrew Morton]

On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> BITS_PER_BYTE is defined in bits.h.
> 
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")

This is post-6.6, so the fix should go into this -rc whatever happens, but...

It would be rather nice to know the effects of this change please.  Did
some build break?

> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_UNITS_H
>  #define _LINUX_UNITS_H
>  
> +#include <linux/bits.h>
>  #include <linux/math.h>
>  
>  /* Metric prefixes in accordance with Système international (d'unités) */
> -- 
> 2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/1] units: Add missing header

[Andy Shevchenko]

On Tue, Nov 28, 2023 at 06:09:57PM -0800, Andrew Morton wrote:
> On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > BITS_PER_BYTE is defined in bits.h.
> > 
> > Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
> 
> This is post-6.6, so the fix should go into this -rc whatever happens, but...
> 
> It would be rather nice to know the effects of this change please.  Did
> some build break?

Not of my knowledge. Fixes tag here to make sure people won't forget that
headers are special and we need a bit stricter rules on how we add a new
stuff (which will require another header) or remove an old one (which may
give a stale inclusion).

-- 
With Best Regards,
Andy Shevchenko