From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B941FC4167B for ; Wed, 29 Nov 2023 14:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234139AbjK2ORA (ORCPT ); Wed, 29 Nov 2023 09:17:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbjK2OQ6 (ORCPT ); Wed, 29 Nov 2023 09:16:58 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41E82AF; Wed, 29 Nov 2023 06:17:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701267425; x=1732803425; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bhjXUMgXeV40oruQhYztJWCViluwOW0nwAoxxNUPFrw=; b=HUNl8vMTV3IZ194T+u9vY4wD5vGTgocJltBtWlLWGeVj7yHkwb8W6iSp OPLwbHS3K3MEskLNYF7qSM+CY1XwC2nUaCoEqqOf0sjUTVNP9H63w3Zqg 90eVq0nIK8XsRpoawziBHfZYnkXslB/oXy4jvqIZeOWbMqXvidbPpjiZj tZeR0WYMfichk8ksd9cYSkjSY5SF11ZTOtGJhLeyb2TNzubKhMybaiXTN k9XqvHJL0ZGfXZUjU7+jg+9Y7EaSd5nsttjLu9is9cEf5CEaYlePF96ef H/uB1JN449c8Qpy0NF5kZ5f1e/wPQbL8jCNY8PCfv9LOYGfBci6SSnDP8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="459665555" X-IronPort-AV: E=Sophos;i="6.04,235,1695711600"; d="scan'208";a="459665555" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 06:17:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="745272986" X-IronPort-AV: E=Sophos;i="6.04,235,1695711600"; d="scan'208";a="745272986" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 06:17:02 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r8LN5-00000000SV2-0AMp; Wed, 29 Nov 2023 16:16:59 +0200 Date: Wed, 29 Nov 2023 16:16:58 +0200 From: Andy Shevchenko To: Petre Rodan Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , Angel Iglesias , Matti Vaittinen , Andreas Klinger , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH v5 2/2] iio: pressure: driver for Honeywell HSC/SSC series pressure sensors Message-ID: References: <20231129070452.1521-1-petre.rodan@subdimension.ro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2023 at 04:14:59PM +0200, Andy Shevchenko wrote: > On Wed, Nov 29, 2023 at 03:51:54PM +0200, Petre Rodan wrote: > > On Wed, Nov 29, 2023 at 12:36:46PM +0200, Andy Shevchenko wrote: > > > On Wed, Nov 29, 2023 at 09:04:49AM +0200, Petre Rodan wrote: ... > > just to have the privilege of using match_string() on hsc_triplet_variants. > > now, which is worse for maintenance? a handful of lines of code that do a > > loop of strncmp or the clutter depicted above? > > > > I can go either way, but I want to make sure you see where this leads. > > That's the suggestion, yes. Btw, if you have any idea how to make a generic API that suits your and similar cases, I'm all ears! -- With Best Regards, Andy Shevchenko