From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282EAC10DAA for ; Thu, 30 Nov 2023 13:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345618AbjK3NjD (ORCPT ); Thu, 30 Nov 2023 08:39:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345563AbjK3NjC (ORCPT ); Thu, 30 Nov 2023 08:39:02 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D871C4; Thu, 30 Nov 2023 05:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701351549; x=1732887549; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+riVxxL383e97L0xvu8Uk6PzvwJHF7/f5CdAalVYZZw=; b=EEFvppcZCRcfqfaHG8xFqIHxxPIpRhuNkPfr8tteSuX5iUAWb5yVcZPW eWZU1+IE0AOWAXeU7F9DNmfIb/+YpPeG7UEM5mvQ5MOFVOvaSRAxl15gg mO/Llq9+DdUamGE6+VDslyU5OgqlDXF3xz8hFbDfFKzgFi40UlqKjBcjs kE6OnY2MsjpavMc4VCOaKA1sFdbgz4563S3NCNNQ0PKQ5L3fr4pZ9ctKw 5PzrsajqLiOiQjv2keYTLhEHZ0JFieGS8HLbMRmvt5/H56Xv4W8RuRSzi SstOHTzTwC/z0yVT/ptLTmsJXAgZNf0x701kIocuABeIHS0xi2Z27tLjz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="372703553" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="372703553" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 05:39:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="942719145" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="942719145" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 05:39:06 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r8hFw-00000000i1T-1BrU; Thu, 30 Nov 2023 15:39:04 +0200 Date: Thu, 30 Nov 2023 15:39:04 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Kent Gibson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] gpio: sim: implement the dbg_show() callback Message-ID: References: <20231130104023.11885-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2023 at 03:37:48PM +0200, Andy Shevchenko wrote: > On Thu, Nov 30, 2023 at 11:40:23AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski ... > > +#else > > +#define gpio_sim_dbg_show NULL > > +#endif /* CONFIG_DEBUG_FS */ > > I;m wondering if you can use PTR_IF() instead of this ugly ifdeffery. If brave enough, you can even propose a new macro like #define debugfs_ptr(ptr) ... (see pm_sleep_ptr() / pm_ptr() as examples). -- With Best Regards, Andy Shevchenko