* [PATCH 1/1] libapi: Add missing linux/types.h header to get the __u64 type on io.h
@ 2023-11-30 17:15 Arnaldo Carvalho de Melo
2023-11-30 17:57 ` Ian Rogers
0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-11-30 17:15 UTC (permalink / raw)
To: Ian Rogers
Cc: Adrian Hunter, Jiri Olsa, Namhyung Kim, linux-kernel,
linux-perf-users
There are functions using __u64, so we need to have the linux/types.h
header otherwise we'll break when its not included before api/io.h.
Fixes: e95770af4c4a280f ("tools api: Add a lightweight buffered reading api")
Cc: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/lkml/
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/api/io.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/lib/api/io.h b/tools/lib/api/io.h
index a77b74c5fb655a8c..2a7fe9758813172d 100644
--- a/tools/lib/api/io.h
+++ b/tools/lib/api/io.h
@@ -12,6 +12,7 @@
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
+#include <linux/types.h>
struct io {
/* File descriptor being read/ */
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] libapi: Add missing linux/types.h header to get the __u64 type on io.h
2023-11-30 17:15 [PATCH 1/1] libapi: Add missing linux/types.h header to get the __u64 type on io.h Arnaldo Carvalho de Melo
@ 2023-11-30 17:57 ` Ian Rogers
0 siblings, 0 replies; 2+ messages in thread
From: Ian Rogers @ 2023-11-30 17:57 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Adrian Hunter, Jiri Olsa, Namhyung Kim, linux-kernel,
linux-perf-users
On Thu, Nov 30, 2023 at 9:15 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> There are functions using __u64, so we need to have the linux/types.h
> header otherwise we'll break when its not included before api/io.h.
>
> Fixes: e95770af4c4a280f ("tools api: Add a lightweight buffered reading api")
> Cc: Ian Rogers <irogers@google.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Link: https://lore.kernel.org/lkml/
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/lib/api/io.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/lib/api/io.h b/tools/lib/api/io.h
> index a77b74c5fb655a8c..2a7fe9758813172d 100644
> --- a/tools/lib/api/io.h
> +++ b/tools/lib/api/io.h
> @@ -12,6 +12,7 @@
> #include <stdlib.h>
> #include <string.h>
> #include <unistd.h>
> +#include <linux/types.h>
>
> struct io {
> /* File descriptor being read/ */
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-30 17:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30 17:15 [PATCH 1/1] libapi: Add missing linux/types.h header to get the __u64 type on io.h Arnaldo Carvalho de Melo
2023-11-30 17:57 ` Ian Rogers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox