From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37DDDC07E97 for ; Fri, 1 Dec 2023 09:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378206AbjLAJdk (ORCPT ); Fri, 1 Dec 2023 04:33:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378190AbjLAJd0 (ORCPT ); Fri, 1 Dec 2023 04:33:26 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8192A55B8 for ; Fri, 1 Dec 2023 01:30:56 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2E42C433C7; Fri, 1 Dec 2023 09:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701423048; bh=JJyOioP4No0etvMhx+FJn3I0kqxY8hhH/XvABdVEB+c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P8MofWVjH1V/KnTQjrJxaHBRnTivjant92hnWgHenSAz4JOZ+wloFxSyjjgtHZg/E sOYcjsYmSy/gmm+pmBekAN608C3+hK/JGyulKD5WvYJEOmGArfi4rrkxoPhJ66dMs+ Srm1T5fVYsgybWHrB7ex8TIptHxfnbOdbgwd1tSxtOUVDNfNVsr1dd9/FLhhg0khwA 96hzoh3swPmaRidIpX60Iue9wOFrraKdCkurF60cOJVMidpdrjBpRVY+0scmCWK6cb Llcj1dO2RpktSaodi2507E1kkGB823B/hVhi8J30M4cOwstKoINfB0J+iGBxDllghW w9ZJec5eme1Hw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r8zrm-0003Fh-1p; Fri, 01 Dec 2023 10:31:22 +0100 Date: Fri, 1 Dec 2023 10:31:22 +0100 From: Johan Hovold To: Krzysztof Kozlowski Cc: Johan Hovold , Alexandre Belloni , Alessandro Zummo , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx: fix inconsistent example Message-ID: References: <20231130173223.12794-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2023 at 09:32:46AM +0100, Krzysztof Kozlowski wrote: > On 30/11/2023 18:32, Johan Hovold wrote: > > The PM8921 is an SSBI PMIC but in the binding example it is described > > as being part of an SPMI PMIC while using an SSBI address. > > > > Make the example consistent by using the sibling PM8941 SPMI PMIC > > instead. > > > > Fixes: 8138c5f0318c ("dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings") > > Similarly to your thermal patch - this is just an example, not a > binding. No bugs are fixed here, no need for backports. A Fixes tag does not in itself imply that something should be backported, we have CC-stable tags for that. And if this was just about the name, I'd agree with you that a Fixes tag is not warranted either, but the way I see this this is more than that as the "spmi" name suggests that these "devices" sit directly on the SPMI bus which would require a different binding entirely. The naming therefore becomes misleading and should be fixed to assist any casual consumer of these binding documents. > Reviewed-by: Krzysztof Kozlowski Thanks for reviewing these. Johan