From: Abel Vesa <abel.vesa@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: martin.petersen@oracle.com, jejb@linux.ibm.com,
andersson@kernel.org, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_cang@quicinc.com
Subject: Re: [PATCH 02/13] scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key()
Date: Fri, 1 Dec 2023 19:49:32 +0200 [thread overview]
Message-ID: <ZWocrM0guCvGSRrQ@linaro.org> (raw)
In-Reply-To: <20231201151417.65500-3-manivannan.sadhasivam@linaro.org>
On 23-12-01 20:44:06, Manivannan Sadhasivam wrote:
> Currently, the function returns -EINVAL if algorithm other than AES-256-XTS
> is requested. But the correct error code is -EOPNOTSUPP. Fix it!
>
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
LGTM.
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index cbb6a696cd97..852179e456f2 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -158,7 +158,7 @@ static int ufs_qcom_ice_program_key(struct ufs_hba *hba,
> cap = hba->crypto_cap_array[cfg->crypto_cap_idx];
> if (cap.algorithm_id != UFS_CRYPTO_ALG_AES_XTS ||
> cap.key_size != UFS_CRYPTO_KEY_SIZE_256)
> - return -EINVAL;
> + return -EOPNOTSUPP;
>
> if (config_enable)
> return qcom_ice_program_key(host->ice,
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-12-01 17:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:14 [PATCH 00/13] scsi: ufs: qcom: Minor code cleanups Manivannan Sadhasivam
2023-12-01 15:14 ` [PATCH 01/13] scsi: ufs: qcom: Use clk_bulk APIs for managing lane clocks Manivannan Sadhasivam
2023-12-06 18:08 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 02/13] scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() Manivannan Sadhasivam
2023-12-01 17:49 ` Abel Vesa [this message]
2023-12-01 15:14 ` [PATCH 03/13] scsi: ufs: qcom: Fix the return value when platform_get_resource_byname() fails Manivannan Sadhasivam
2023-12-06 18:11 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 04/13] scsi: ufs: qcom: Remove superfluous variable assignments Manivannan Sadhasivam
2023-12-06 18:15 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 05/13] scsi: ufs: qcom: Remove the warning message when core_reset is not available Manivannan Sadhasivam
2023-12-06 18:36 ` Andrew Halaney
2023-12-07 5:18 ` Manivannan Sadhasivam
2023-12-07 13:50 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 06/13] scsi: ufs: qcom: Export ufshcd_{enable/disable}_irq helpers and make use of them Manivannan Sadhasivam
2023-12-01 20:27 ` Bart Van Assche
2023-12-01 15:14 ` [PATCH 07/13] scsi: ufs: qcom: Fail ufs_qcom_power_up_sequence() when core_reset fails Manivannan Sadhasivam
2023-12-06 18:41 ` Andrew Halaney
2023-12-07 5:26 ` Manivannan Sadhasivam
2023-12-01 15:14 ` [PATCH 08/13] scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence() Manivannan Sadhasivam
2023-12-06 18:43 ` Andrew Halaney
2023-12-07 8:27 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 09/13] scsi: ufs: qcom: Remove redundant error print for devm_kzalloc() failure Manivannan Sadhasivam
2023-12-07 8:36 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 10/13] scsi: ufs: qcom: Use dev_err_probe() to simplify error handling of devm_gpiod_get_optional() Manivannan Sadhasivam
2023-12-06 18:52 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 11/13] scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array Manivannan Sadhasivam
2023-12-06 18:54 ` Andrew Halaney
2023-12-07 5:31 ` Manivannan Sadhasivam
2023-12-07 13:46 ` Andrew Halaney
2023-12-07 8:43 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 12/13] scsi: ufs: qcom: Sort includes alphabetically Manivannan Sadhasivam
2023-12-05 16:35 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 13/13] scsi: ufs: qcom: Initialize cycles_in_1us variable in ufs_qcom_set_core_clk_ctrl() Manivannan Sadhasivam
2023-12-05 16:33 ` Nitin Rawat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWocrM0guCvGSRrQ@linaro.org \
--to=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox