From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600D5C4167B for ; Fri, 1 Dec 2023 17:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379022AbjLARtc (ORCPT ); Fri, 1 Dec 2023 12:49:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbjLARta (ORCPT ); Fri, 1 Dec 2023 12:49:30 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C09AC for ; Fri, 1 Dec 2023 09:49:36 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40838915cecso22932245e9.2 for ; Fri, 01 Dec 2023 09:49:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701452975; x=1702057775; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c3XtzzjFOgOD7S4u56J6oC5ewGwOzGezjwSu4l5fq5g=; b=sm4ZZFq91CY8lte9F47e4X3zAOAXsm8t0eBH4BO5uNmn8snvKeCbHYnHIAp2JWAAtW MG1DDiYdDAIvxQp1y8Ld80lV3YYSKMR+bpPEsVMn9dXe0Q+9XYux5wRuMRhegWh5xNAa Ymii+///SgDCozKE9LYdr+r3o2yQYeU72SualleKfb84fsqpEK0U209KwA5StV97OF6W 2I59evkBsqq3QaEOQE/U755uBLCo9YjoqiZFYbPK1sBGmD1yhSi5lkD+sGMN256xQctB l9thj3vJV+iz5nuJZZ1YmWWNpzdJSLQBC5gBoz+sGNvw9xUUSqxawKIhECfZ0C3XKYbL c9Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701452975; x=1702057775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c3XtzzjFOgOD7S4u56J6oC5ewGwOzGezjwSu4l5fq5g=; b=jgKTP7kKrcTX6Z6pAUBfigKwPMwKUzFqL1g+UoQVHoPDlhrikcgS4j5rGPnWaRXCA/ Nv9wxHln9TDZHp1UvOlfDEFmerM9JHF36zy/FF8RkzUAOBj3R+3rS+iz3SDK64siXdsh gzd6M7o667xSNMC6WbTS1LiHXT8k2d7xwLBwdwDpzvN3QjI2prr+qQ9w7NC/A0m5xsib HgPQHpw1r9MBtZZu5/ffM3Anh7VHdRqoWF87GcKTKOgfFuU385k/crkbp3vp821WYy15 +0nsDjGngvva5sZGiqpLKZ3XrXD0/8POLeNwBCVZyw+jACVB4r9SfK/EcJOl7fyuhxPD yaYw== X-Gm-Message-State: AOJu0Yy8skMu3CDcs1Wso7b0hOto6dXzYtwE1ljAB/BDtASKrSI1Xk6i SmcJozmTHB6t9Zd9W8qU2VGY9A== X-Google-Smtp-Source: AGHT+IFHuFmbI9cOvT54OXa90QPoF6aFMDHPdlfYs5Ijr3TiN58L/m9EWHXlGpDb4KgfEboYZKC0EQ== X-Received: by 2002:a05:600c:4f03:b0:40b:2a15:9b30 with SMTP id l3-20020a05600c4f0300b0040b2a159b30mr447078wmq.1.1701452975070; Fri, 01 Dec 2023 09:49:35 -0800 (PST) Received: from linaro.org ([82.77.85.67]) by smtp.gmail.com with ESMTPSA id dl17-20020a0560000b9100b003316debbde4sm4777931wrb.48.2023.12.01.09.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:49:34 -0800 (PST) Date: Fri, 1 Dec 2023 19:49:32 +0200 From: Abel Vesa To: Manivannan Sadhasivam Cc: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com Subject: Re: [PATCH 02/13] scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() Message-ID: References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> <20231201151417.65500-3-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201151417.65500-3-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-12-01 20:44:06, Manivannan Sadhasivam wrote: > Currently, the function returns -EINVAL if algorithm other than AES-256-XTS > is requested. But the correct error code is -EOPNOTSUPP. Fix it! > > Cc: Abel Vesa > Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API") > Signed-off-by: Manivannan Sadhasivam LGTM. Reviewed-by: Abel Vesa > --- > drivers/ufs/host/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index cbb6a696cd97..852179e456f2 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -158,7 +158,7 @@ static int ufs_qcom_ice_program_key(struct ufs_hba *hba, > cap = hba->crypto_cap_array[cfg->crypto_cap_idx]; > if (cap.algorithm_id != UFS_CRYPTO_ALG_AES_XTS || > cap.key_size != UFS_CRYPTO_KEY_SIZE_256) > - return -EINVAL; > + return -EOPNOTSUPP; > > if (config_enable) > return qcom_ice_program_key(host->ice, > -- > 2.25.1 >