From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BECABC4167B
	for <linux-kernel@archiver.kernel.org>; Wed,  6 Dec 2023 22:37:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229740AbjLFWhW (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 6 Dec 2023 17:37:22 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42196 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231128AbjLFWhT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Dec 2023 17:37:19 -0500
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 756A410C6
        for <linux-kernel@vger.kernel.org>; Wed,  6 Dec 2023 14:37:24 -0800 (PST)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04672C433C7;
        Wed,  6 Dec 2023 22:37:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1701902244;
        bh=SpHMtoBxIkmYrYXlggD/bi1zaqbK4AdCKk/C2BprrYU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=qW35m9mQvl/FxtFLb4vNeX3KAGURfIyLQFALthVHe3pChiNyjfjfmZezgHouAPoDA
         K2FLC+/OwqfM2goIgGuqWuXvu22A9VkKt1B3ZxsgDvo/SOww1F6vOF9UuBTYizK+Vu
         PKV8PqhoJ6SWA5jjs1xYc5nEyhwaZJvBndUVCYC4LrDs2g1oaMs5EPpBCE33e56Wgi
         j0wPZE4Se3xhKOPPFgLJW15egZLwnEJZWelNxeC9z4FTIM1ymwrOaUWtros2tsy2Wx
         9DBtKtBX6KcycNiL+sSWGBoP224WPg38w8PR7o+eZLH+QKLt2i+gJWaDLw0QT70Zn5
         +KFjh9f68sy2Q==
Date:   Wed, 6 Dec 2023 14:37:22 -0800
From:   Saeed Mahameed <saeed@kernel.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] net/mlx5: DR, Use swap() instead of open coding it
Message-ID: <ZXD3orTxU0mxi5jH@x130>
References: <20231117071947.112856-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20231117071947.112856-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17 Nov 15:19, Jiapeng Chong wrote:
>Swap is a function interface that provides exchange function. To avoid
>code duplication, we can use swap function.
>
>./drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1254:50-51: WARNING opportunity for swap().
>
>Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7580
>Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>---

applied to net-next-mlx5
-Saeed.