From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: kan.liang@linux.intel.com
Cc: irogers@google.com, peterz@infradead.org, mingo@redhat.com,
namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
john.g.garry@oracle.com, will@kernel.org, james.clark@arm.com,
mike.leach@linaro.org, leo.yan@linaro.org,
yuhaixin.yhx@linux.alibaba.com, renyu.zj@linux.alibaba.com,
tmricht@linux.ibm.com, ravi.bangoria@amd.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] perf mem: Remove useless header files for X86
Date: Wed, 6 Dec 2023 17:38:48 -0300 [thread overview]
Message-ID: <ZXDb2Gs1ECjejSbn@kernel.org> (raw)
In-Reply-To: <20231206201324.184059-7-kan.liang@linux.intel.com>
Em Wed, Dec 06, 2023 at 12:13:24PM -0800, kan.liang@linux.intel.com escreveu:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> The X86 mem-events.c only has perf_mem_events array now. Remove useless
> header files.
It would be great that those were removed while you made the cleanups,
i.e. removed the need for one of them, remove it together with the
refactorings, etc.
But I don't think this is a requirement, just would make it cleaner.
Will wait for reviews now.
- Arnaldo
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> ---
> tools/perf/arch/x86/util/mem-events.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/mem-events.c b/tools/perf/arch/x86/util/mem-events.c
> index 71ffe16de751..62df03e91c7e 100644
> --- a/tools/perf/arch/x86/util/mem-events.c
> +++ b/tools/perf/arch/x86/util/mem-events.c
> @@ -1,11 +1,9 @@
> // SPDX-License-Identifier: GPL-2.0
> -#include "util/pmu.h"
> -#include "util/pmus.h"
> -#include "util/env.h"
> -#include "map_symbol.h"
> -#include "mem-events.h"
> #include "linux/string.h"
> -#include "env.h"
> +#include "util/map_symbol.h"
> +#include "util/mem-events.h"
> +#include "mem-events.h"
> +
>
> #define MEM_LOADS_AUX 0x8203
>
> --
> 2.35.1
>
--
- Arnaldo
next prev parent reply other threads:[~2023-12-06 20:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 20:13 [PATCH 0/6] Clean up perf mem kan.liang
2023-12-06 20:13 ` [PATCH 1/6] perf mem: Add mem_events into the supported perf_pmu kan.liang
2023-12-06 21:01 ` Ian Rogers
2023-12-07 14:21 ` Ravi Bangoria
2023-12-07 14:27 ` Liang, Kan
2023-12-06 20:13 ` [PATCH 2/6] perf mem: Clean up perf_mem_events__ptr() kan.liang
2023-12-06 21:04 ` Ian Rogers
2023-12-07 14:42 ` Liang, Kan
2023-12-06 20:13 ` [PATCH 3/6] perf mem: Clean up perf_mem_events__name() kan.liang
2023-12-06 21:07 ` Ian Rogers
2023-12-06 21:52 ` Liang, Kan
2023-12-06 20:13 ` [PATCH 4/6] perf mem: Clean up perf_mem_event__supported() kan.liang
2023-12-06 21:08 ` Ian Rogers
2023-12-06 20:13 ` [PATCH 5/6] perf mem: Clean up is_mem_loads_aux_event() kan.liang
2023-12-06 21:10 ` Ian Rogers
2023-12-06 20:13 ` [PATCH 6/6] perf mem: Remove useless header files for X86 kan.liang
2023-12-06 20:38 ` Arnaldo Carvalho de Melo [this message]
2023-12-06 21:53 ` Liang, Kan
2023-12-07 14:44 ` [PATCH 0/6] Clean up perf mem Ravi Bangoria
2023-12-07 15:05 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXDb2Gs1ECjejSbn@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=tmricht@linux.ibm.com \
--cc=will@kernel.org \
--cc=yuhaixin.yhx@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox