From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA45C4167B for ; Thu, 7 Dec 2023 12:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379084AbjLGMBp (ORCPT ); Thu, 7 Dec 2023 07:01:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231439AbjLGMBn (ORCPT ); Thu, 7 Dec 2023 07:01:43 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84DB1AA; Thu, 7 Dec 2023 04:01:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701950509; x=1733486509; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=APk8BnUEAD3kMbuSbw1mcu8TmnFWgLBT+IUePjKQZeE=; b=CBZ59ry5/leUv5Bs39R3nlDHhmUTWqKko5nQ+EewLX2HwHM18DDD24mN 7P8pFG2uRdD2gwYeILqO8Rmsx5WqiuH2nB/fWtF0B6bfjP1pYBiFtpRCe 5htZQPHmy6dHqvTXzfAR/o0t8kiTNA5bEi/aqXuRJ1P4IBo2Fl58GOYRo if4iCPnX7Lrcb4Hw8eRHABjBWYgDZNckzeLsAC5BXCq16l7a0s7tHBEZp 4HCtLyDmMtDGG1M+PWa7DzQ8uT5Tgvw/eYwgh1cDIuAQnYKIOLUQGGSCR QYv1Tjxz8RXtRT83FXfyed4zMBcxcnPZbtozL2JVHVwjQBw29xv/29Q60 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="1100881" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="1100881" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 04:01:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="862452336" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="862452336" Received: from kuha.fi.intel.com ([10.237.72.185]) by FMSMGA003.fm.intel.com with SMTP; 07 Dec 2023 04:01:46 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 07 Dec 2023 14:01:45 +0200 Date: Thu, 7 Dec 2023 14:01:45 +0200 From: Heikki Krogerus To: Dmitry Baryshkov Cc: Arnd Bergmann , Greg Kroah-Hartman , Arnd Bergmann , Neil Armstrong , Bjorn Andersson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency Message-ID: References: <20231206123828.587065-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 07, 2023 at 01:58:31PM +0200, Dmitry Baryshkov wrote: > On Thu, 7 Dec 2023 at 13:57, Heikki Krogerus > wrote: > > > > On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote: > > > On Thu, 7 Dec 2023 at 13:53, Heikki Krogerus > > > wrote: > > > > > > > > On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote: > > > > > From: Arnd Bergmann > > > > > > > > > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed > > > > > here to avoid a build failure: > > > > > > > > > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE > > > > > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > > > > > Selected by [y]: > > > > > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] > > > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register': > > > > > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init' > > > > > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add' > > > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init': > > > > > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register' > > > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit': > > > > > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister' > > > > > > > > > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") > > > > > Signed-off-by: Arnd Bergmann > > > > > --- > > > > > drivers/usb/typec/mux/Kconfig | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > > > > > index 5120942f309d..818624f59120 100644 > > > > > --- a/drivers/usb/typec/mux/Kconfig > > > > > +++ b/drivers/usb/typec/mux/Kconfig > > > > > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M > > > > > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" > > > > > depends on I2C > > > > > depends on DRM || DRM=n > > > > > + depends on OF > > > > > select DRM_AUX_BRIDGE if DRM_BRIDGE > > > > > select REGMAP_I2C > > > > > help > > > > > > > > Shouldn't DRM_BRIDGE depend on OF instead? > > > > > > No. DRM_AUX_BRIDGE depends on OF, DRM_BRIDGE framework doesn't. > > > > Okay, so this probable should also be > > > > select DRM_AUX_BRIDGE if DRM_BRIDGE and OF > > Yes, this is what a patch from Nathan does: > https://patchwork.freedesktop.org/patch/570638/?series=127385&rev=1 Ah, sorry about the noise. thanks, -- heikki