From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A072DC4167B for ; Thu, 7 Dec 2023 11:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379090AbjLGLxr (ORCPT ); Thu, 7 Dec 2023 06:53:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232523AbjLGLxo (ORCPT ); Thu, 7 Dec 2023 06:53:44 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D81CD10C0; Thu, 7 Dec 2023 03:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701950029; x=1733486029; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3EFdU9bF0fb0rJIymq1oYQWqxw2gxZ/VsdFmjDVVlnY=; b=dFql21k8fKtQ/AKcGvh7AfA7qYgY2Fe72g3WK56ZSGu/ddqVRdTUXpST A9umcs8L8gOmsv5xjWLjf+aL7kD0AppnLluAheM2H6QicC+YTPHrjVl5t NVeGYlF7vBOJ2kaIcWdO0MlhZAUFAgvAgxU54R1D6LWjkTLa9lYaHSsN9 V0jaRgIl7ORX8mbH2i2nJdp3OK1UvpK+ljjvWxANr/dyrZjCnmKvzjl11 NbWpnOZjPmumiHFOvhM8femVXPVZBTsH3cwsDS5Hbm1kWLEzxWs5sUJgF Rud/+1jkrSLqMCWbJCaBkP5S7XnvNMXPZtwpvpz5P+IvDFuLoy9N0bQ/D w==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="7579699" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="7579699" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 03:53:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="895122755" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="895122755" Received: from kuha.fi.intel.com ([10.237.72.185]) by orsmga004.jf.intel.com with SMTP; 07 Dec 2023 03:53:45 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 07 Dec 2023 13:53:44 +0200 Date: Thu, 7 Dec 2023 13:53:44 +0200 From: Heikki Krogerus To: Arnd Bergmann Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Arnd Bergmann , Neil Armstrong , Bjorn Andersson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency Message-ID: References: <20231206123828.587065-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231206123828.587065-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed > here to avoid a build failure: > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [y]: > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register': > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init' > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add' > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init': > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register' > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit': > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister' > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") > Signed-off-by: Arnd Bergmann > --- > drivers/usb/typec/mux/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > index 5120942f309d..818624f59120 100644 > --- a/drivers/usb/typec/mux/Kconfig > +++ b/drivers/usb/typec/mux/Kconfig > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" > depends on I2C > depends on DRM || DRM=n > + depends on OF > select DRM_AUX_BRIDGE if DRM_BRIDGE > select REGMAP_I2C > help Shouldn't DRM_BRIDGE depend on OF instead? thanks, -- heikki