From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB13C4167B for ; Fri, 8 Dec 2023 20:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574720AbjLHUgR (ORCPT ); Fri, 8 Dec 2023 15:36:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234175AbjLHUgO (ORCPT ); Fri, 8 Dec 2023 15:36:14 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E6FF198D for ; Fri, 8 Dec 2023 12:36:20 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5ca26c07848so32219717b3.0 for ; Fri, 08 Dec 2023 12:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702067779; x=1702672579; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=orHiJZT0C6fy8Fk3kj9J2cROYJthdQ2Wc1XwHn5ZMq4=; b=3ln6m9oI3jDYCkIaLkrprMOPDZL4zJLDkHJeUd5TD8ROVnPxu6QusfweP8eUz1WUyi wQvVpdwjLE3YzrqKuwb3sWcVJRWaFjDupLV2U96fw1mDUCpK/d7HFfMhFDu7fTSl83eu n1QLUdGLK5It7eLF3CnQAfXHK138ENkZB1SyZJ4FEfFzLHhiJUDCgYd/he5K2JEc0BIH meA4MobzMMmZ5XmU0RACo8+mqGSlcJ0tIjYI0ws79e0/crMfwSttuwNo99Vm+ZEzOQzK 2aiU+4SLLY8VysAsuqC8RGhr6Lc3ztkLhZO1nFwvAHfksOT1VofCKXP9Kt3u5AHyuFTI QQ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702067779; x=1702672579; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=orHiJZT0C6fy8Fk3kj9J2cROYJthdQ2Wc1XwHn5ZMq4=; b=dQ26mikrjafySIG/6b8u8Hnx0SEExOaChrUu4r8YI4klQS8WwyFBr564ewuKlPbcHd Vq8IDIE97ASAB2x9N19lSX7pbbKtlOLJrOcn0bBzRkK6HpMDyJhjdjO/X/KxIL8GfGyL wND4T1OwQisSZg+WF62HldIN8y7/a8ktZseBXOXkiB0cqW0LSyGBJ8jeA+jpt+UtrFkR TSGAET3ws2S4P9+VUAnHguWvXDvMu5IgSMQ/r5GiS/E740BhI4GVlZmT7lLR5oqZn+HT 3H9hJGvBsZW+0K6oqLhIAdS48OHY4Mleyl6xJCQr7VgcCwfQZakZvi9ySuyHUN/CncI2 WePA== X-Gm-Message-State: AOJu0YxZAZx+UBI89rN/FukpYDzxDk6ZqjVYTQg57L4qeAa16etWhb8Y F4UshmAl/bnXexqMeGVIELZDMm80XGE= X-Google-Smtp-Source: AGHT+IGM36poiI66KimXwnmZMFV+cug+a/f2/aHqYZGdi3tEpQylnxIgmZTLgmZqxePMHXCOG7mBMbzoJbc= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:d1e:b0:5d2:913a:6421 with SMTP id cn30-20020a05690c0d1e00b005d2913a6421mr5795ywb.8.1702067779340; Fri, 08 Dec 2023 12:36:19 -0800 (PST) Date: Fri, 8 Dec 2023 12:36:17 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231205234956.1156210-1-michael.roth@amd.com> Message-ID: Subject: Re: [PATCH] KVM: SEV: Fix handling of EFER_LMA bit when SEV-ES is enabled From: Sean Christopherson To: Paolo Bonzini Cc: Michael Roth , kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2023, Paolo Bonzini wrote: > On Wed, Dec 6, 2023 at 4:28=E2=80=AFPM Sean Christopherson wrote: > > So my very strong preference is to first skip the kvm_is_valid_sregs() = check >=20 > No, please don't. If you want to add a quirk that, when disabled, > causes all guest state get/set ioctls to fail, go ahead. But invalid > processor state remains invalid, and should be rejected, even when KVM > won't consume it. Ugh, true, KVM should still reject garbage.