Re: [PATCH v1] KVM: selftests: Fix Assertion on non-x86_64 platforms

Sean Christopherson
2023-12-08T16:21:19Z

On Thu, Dec 07, 2023, Shaoqin Huang wrote:
> When running the set_memory_region_test on arm64 platform, it causes the
> below assert:
>
> ==== Test Assertion Failure ====
> set_memory_region_test.c:355: r && errno == EINVAL
> pid=40695 tid=40695 errno=0 - Success
> 1 0x0000000000401baf: test_invalid_memory_region_flags at set_memory_region_test.c:355
> 2 (inlined by) main at set_memory_region_test.c:541
> 3 0x0000ffff951c879b: ?? ??:0
> 4 0x0000ffff951c886b: ?? ??:0
> 5 0x0000000000401caf: _start at ??:?
> KVM_SET_USER_MEMORY_REGION should have failed on v2 only flag 0x2
>
> This is because the arm64 platform also support the KVM_MEM_READONLY flag, but
> the current implementation add it into the supportd_flags only on x86_64
> platform, so this causes assert on other platform which also support the
> KVM_MEM_READONLY flag.
>
> Fix it by using the __KVM_HAVE_READONLY_MEM macro to detect if the
> current platform support the KVM_MEM_READONLY, thus fix this problem on
> all other platform which support KVM_MEM_READONLY.
>
> Fixes: 5d74316466f4 ("KVM: selftests: Add a memory region subtest to validate invalid flags")
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---

/facepalm

Reviewed-by: Sean Christopherson <seanjc@google.com>