From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4616C4167B for ; Fri, 8 Dec 2023 17:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233682AbjLHRB1 (ORCPT ); Fri, 8 Dec 2023 12:01:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232094AbjLHRBZ (ORCPT ); Fri, 8 Dec 2023 12:01:25 -0500 Received: from gofer.mess.org (gofer.mess.org [IPv6:2a02:8011:d000:212::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF767D54; Fri, 8 Dec 2023 09:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1702054886; bh=0qFeptaVkBsmj5kyQRxzgnQQfozxB3P91OikGk9d6cE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=epC/ZO2uTJ4Zn/UcJOhtNv/kkrvpLb8GaMOQxaP/LYWGBRGqVpVS3v014yYA98UV8 MYvvYpaX6sQ1KgXK9ujvYCYF/cKElPsf3SMv3UNz6YEfpPhsDJbCLDN8sXtUAburNn piT2eVnZFFdm0+7GmL2FYH8JyfGSm5LmTowobSA/svH10Zd6jvaLK2zr//Clf9i88C Hf7pKQK+kH6T/Gxmh9hPcY3NnfUPbbGX0iNrEpMcUgIFa6cEQsUhDbHZEaGRKhE/yY ibu2Sbqosc+ncAf4kpC6j8xW+1W+q80DsMwDVZEYXZqQ7nXCAbFWYGYLxN83D1urBN 23VVLFxFlmwUw== Received: by gofer.mess.org (Postfix, from userid 1000) id 83520100091; Fri, 8 Dec 2023 17:01:26 +0000 (GMT) Date: Fri, 8 Dec 2023 17:01:26 +0000 From: Sean Young To: Thierry Reding Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/4] pwm: bcm2835: allow pwm driver to be used in atomic context Message-ID: References: <179dc1ce85702a8b64b43c0e0df656b0c5e3ce30.1701248996.git.sean@mess.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2023 at 05:22:52PM +0100, Thierry Reding wrote: > On Wed, Nov 29, 2023 at 09:13:36AM +0000, Sean Young wrote: > > clk_get_rate() may do a mutex lock. Fetch the clock rate once, and prevent > > rate changes using clk_rate_exclusive_get(). > > > > Signed-off-by: Sean Young > > --- > > drivers/pwm/pwm-bcm2835.c | 31 +++++++++++++++++++++---------- > > 1 file changed, 21 insertions(+), 10 deletions(-) > > s/pwm/PWM/ in the subject. Although, I guess you could just drop the > "PWM" altogether because the subject prefix implies that this is for > PWM. $ git log --no-merges --oneline drivers/pwm/ | sed -r 's/^\w* ([^:]+): .*/\1/' | sort | uniq -c 1197 pwm 1 PWM ... The vast majority of the commits use pwm: as a prefix, only one uses PWM:. In fact if you look across the tree almost everywhere lower case is used for the prefix. I'm just trying to follow convention. Having said that, I think the prefix is totally redundant, it is clear from the commit files what they are affecting. I am not sure what it really adds. > Also, please capitalize after the subject prefix. $ git log --no-merges --oneline drivers/pwm/ | grep -E '^\w* ([^:]+): [A-Z]' | wc -l 217 $ git log --no-merges --oneline drivers/pwm/ | grep -E '^\w* ([^:]+): [a-z]' | wc -l 1069 Although not as clear, convention seems to be lower case for commits. The first line of a commit is not really a sentence, there is no trailing period. I am happy to oblige, just wanted to point this out. Sorry if this starts a bikeshed discussion. Thanks, Sean