Re: [PATCH v2 13/35] KVM: x86: hyper-v: optimize and cleanup kvm_hv_process_stimers()

Sean Christopherson
2023-12-04T16:00:39Z

On Mon, Dec 04, 2023, Vitaly Kuznetsov wrote:
> > - for (i = 0; i < ARRAY_SIZE(hv_vcpu->stimer); i++)
> > - if (test_and_clear_bit(i, hv_vcpu->stimer_pending_bitmap)) {
> > - stimer = &hv_vcpu->stimer[i];
> > - if (stimer->config.enable) {
> > - exp_time = stimer->exp_time;
> > -
> > - if (exp_time) {
> > - time_now =
> > - get_time_ref_counter(vcpu->kvm);
> > - if (time_now >= exp_time)
> > - stimer_expiration(stimer);
> > - }
> > -
> > - if ((stimer->config.enable) &&
> > - stimer->count) {
> > - if (!stimer->msg_pending)
> > - stimer_start(stimer);
> > - } else
> > - stimer_cleanup(stimer);
> > - }
> > + for_each_test_and_clear_bit(i, hv_vcpu->stimer_pending_bitmap,
> > + ARRAY_SIZE(hv_vcpu->stimer)) {

Another nit, please align the indendation:

for_each_test_and_clear_bit(i, hv_vcpu->stimer_pending_bitmap,
ARRAY_SIZE(hv_vcpu->stimer)) {

> > + stimer = &hv_vcpu->stimer[i];
> > + if (!stimer->config.enable)
> > + continue;
> > +
> > + exp_time = stimer->exp_time;
> > +
> > + if (exp_time) {
> > + time_now = get_time_ref_counter(vcpu->kvm);
> > + if (time_now >= exp_time)
> > + stimer_expiration(stimer);
> > }
> > +
> > + if (stimer->config.enable && stimer->count) {
> > + if (!stimer->msg_pending)
> > + stimer_start(stimer);
> > + } else
> > + stimer_cleanup(stimer);
>
> Minor nitpick: it's better (and afair required by coding style) to use
> '{}' for both branches here:

Yeah, it's a hard requirement in KVM x86.

>
> if (stimer->config.enable && stimer->count) {
> if (!stimer->msg_pending)
> stimer_start(stimer);
> } else {
> stimer_cleanup(stimer);
> }
>
> > + }
> > }
> >
> > void kvm_hv_vcpu_uninit(struct kvm_vcpu *vcpu)
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> --
> Vitaly
>