The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Emil Velikov <emil.velikov@collabora.com>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
	Marian Postevca <posteuca@mutex.one>,
	Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
	Syed Saba Kareem <Syed.SabaKareem@amd.com>,
	Alper Nebi Yasak <alpernebiyasak@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Rander Wang <rander.wang@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
	Bard Liao <bard.liao@intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH 0/5] Improve AMD ACP Vangogh audio support for Steam Deck OLED
Date: Mon, 11 Dec 2023 15:12:54 +0000	[thread overview]
Message-ID: <ZXcm9v0vgnc7gGfc@arch-x395> (raw)
In-Reply-To: <20231209203229.878730-1-cristian.ciocaltea@collabora.com>

On 2023/12/09, Cristian Ciocaltea wrote:
> This patch series provides several fixes and improvements to AMD ACP drivers
> targeting the Vangogh platform, as found on the Valve's new Steam Deck OLED.
> 
> Although in theory the board should have been supported by both SOF and legacy
> ACP drivers, as of next-20231208 the audio seems to be completely broken.
> 
> Please note this only restores the legacy support, while SOF will be handled in
> a separate series.
> 
> Cristian Ciocaltea (5):
>   ASoC: amd: vangogh: Drop conflicting ACPI-based probing
>   ASoC: amd: vangogh: Allow probing ACP PCI when SOF is disabled
>   ASoC: amd: vangogh: Switch to {RUNTIME,SYSTEM_SLEEP}_PM_OPS
>   ASoC: amd: acp-config: Add missing MODULE_DESCRIPTION
>   ASoC: amd: acp: Add missing MODULE_DESCRIPTION in mach-common
> 

If it were me, I'd drop the Fixes tag in the latter two patches since
the warning is harmless and as-is it'll get into the -stable
maintainers' list, who are already pretty swamped with patches.

Regardless, for the series:
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

HTH
Emil

  parent reply	other threads:[~2023-12-11 15:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09 20:32 [PATCH 0/5] Improve AMD ACP Vangogh audio support for Steam Deck OLED Cristian Ciocaltea
2023-12-09 20:32 ` [PATCH 1/5] ASoC: amd: vangogh: Drop conflicting ACPI-based probing Cristian Ciocaltea
2023-12-09 20:32 ` [PATCH 2/5] ASoC: amd: vangogh: Allow probing ACP PCI when SOF is disabled Cristian Ciocaltea
2023-12-09 20:32 ` [PATCH 3/5] ASoC: amd: vangogh: Switch to {RUNTIME,SYSTEM_SLEEP}_PM_OPS Cristian Ciocaltea
2023-12-09 20:32 ` [PATCH 4/5] ASoC: amd: acp-config: Add missing MODULE_DESCRIPTION Cristian Ciocaltea
2023-12-09 20:32 ` [PATCH 5/5] ASoC: amd: acp: Add missing MODULE_DESCRIPTION in mach-common Cristian Ciocaltea
2023-12-11 15:12 ` Emil Velikov [this message]
2023-12-11 17:04   ` [PATCH 0/5] Improve AMD ACP Vangogh audio support for Steam Deck OLED Cristian Ciocaltea
2023-12-19 18:06 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXcm9v0vgnc7gGfc@arch-x395 \
    --to=emil.velikov@collabora.com \
    --cc=AjitKumar.Pandey@amd.com \
    --cc=Syed.SabaKareem@amd.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=daniel.baluta@nxp.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=kernel@collabora.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=posteuca@mutex.one \
    --cc=rander.wang@intel.com \
    --cc=tiwai@suse.com \
    --cc=venkataprasad.potturu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox