From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BB2C4332F for ; Tue, 12 Dec 2023 09:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346182AbjLLJSK (ORCPT ); Tue, 12 Dec 2023 04:18:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbjLLJSI (ORCPT ); Tue, 12 Dec 2023 04:18:08 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE1F5D2 for ; Tue, 12 Dec 2023 01:18:13 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40c41df5577so23808595e9.0 for ; Tue, 12 Dec 2023 01:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1702372692; x=1702977492; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9WELy4DAZTSrhx4zGGjgQkw3W/tbMhWv9d+cZpR74m0=; b=h3nFpstoqypwlitXuvf2NCctFsAFDjzPZDUy+RZZBGUaFh1vHxl1kBiexRPf7OaJvt m8hMrx6mSz5PV1gimgHJ7nbKviJa0r5VxC3gVNZUSvMB/MbUk61ug2cJzalI7jlipIVA BpMtkubWuyPIUyXFbBL7fBUTIYhsPpd0OBfUM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702372692; x=1702977492; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9WELy4DAZTSrhx4zGGjgQkw3W/tbMhWv9d+cZpR74m0=; b=bm2Mbb5rwmfRPlIIg7qNV3UJc3bik420F2aS2lo+bHI3qtq3dQ4wkR9dsv3Z0qZh0e 2h/SaOM49bbUbSJmAM+jZwjHVAmlHN56+QsMOpC9miIuR1wy65bxT37/BlbhPqqr4xfZ +ws08CR4y+QaMWcEhn97/WvwlVgVE/XcFRPPAnkHFeoR+ow9hhdc4uCT5d9epTAV9sQf NQI5q1Dfv0CNzi2dQYFIc+uDoJLucRlo5IeSUi9jLJoeOQ+zWvsccWoAReiJtkPpihdk 4+8zNWpRSdM9tLQTgaP/9Cr6cFX6mLwyH4kHxR1WVn6hvLdylFATnxPeD6EVx3B5+qzq rAEQ== X-Gm-Message-State: AOJu0Yw6hE2vOAx9u4JLrccSW1uAFp2JilHCs9sh/8OyeFVefqd5cPfB QK065ujmnZlxVyv3VWS+FhwuwQ== X-Google-Smtp-Source: AGHT+IFgKgRKA6Hj8FA4QbKIfcIE89wBNkiyNGzHcW1HguHNOiTJp2Iwm2e75u6BvwbtAJwHlC1s8w== X-Received: by 2002:a05:600c:1c1f:b0:40b:4c54:3d6d with SMTP id j31-20020a05600c1c1f00b0040b4c543d6dmr1419794wms.8.1702372692352; Tue, 12 Dec 2023 01:18:12 -0800 (PST) Received: from localhost ([213.195.113.99]) by smtp.gmail.com with ESMTPSA id t9-20020a05600c198900b0040c490db950sm5631023wmq.47.2023.12.12.01.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 01:18:12 -0800 (PST) Date: Tue, 12 Dec 2023 10:18:11 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Chen, Jiqian" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Thomas Gleixner , Boris Ostrovsky , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "Deucher, Alexander" , "Koenig, Christian" , "Hildebrand, Stewart" , "Ragiadakou, Xenia" , "Huang, Honglei1" , "Zhang, Julia" , "Huang, Ray" Subject: Re: [RFC KERNEL PATCH v3 3/3] PCI/sysfs: Add gsi sysfs for pci_dev Message-ID: References: <20231210161519.1550860-1-Jiqian.Chen@amd.com> <20231210161519.1550860-4-Jiqian.Chen@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 12, 2023 at 06:34:27AM +0000, Chen, Jiqian wrote: > > On 2023/12/12 01:57, Roger Pau Monné wrote: > > On Mon, Dec 11, 2023 at 12:15:19AM +0800, Jiqian Chen wrote: > >> There is a need for some scenarios to use gsi sysfs. > >> For example, when xen passthrough a device to dumU, it will > >> use gsi to map pirq, but currently userspace can't get gsi > >> number. > >> So, add gsi sysfs for that and for other potential scenarios. > >> > >> Co-developed-by: Huang Rui > >> Signed-off-by: Jiqian Chen > >> --- > >> drivers/acpi/pci_irq.c | 1 + > >> drivers/pci/pci-sysfs.c | 11 +++++++++++ > >> include/linux/pci.h | 2 ++ > >> 3 files changed, 14 insertions(+) > >> > >> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c > >> index 630fe0a34bc6..739a58755df2 100644 > >> --- a/drivers/acpi/pci_irq.c > >> +++ b/drivers/acpi/pci_irq.c > >> @@ -449,6 +449,7 @@ int acpi_pci_irq_enable(struct pci_dev *dev) > >> kfree(entry); > >> return 0; > >> } > >> + dev->gsi = gsi; > > > > It would be better if the gsi if fetched without requiring calling > > acpi_pci_irq_enable(), as the gsi doesn't require the interrupt to be > > enabled. The gsi is known at boot time and won't change for the > > lifetime of the device. > Do you have any suggest places to do this? I'm not an expert on this, but drivers/pci/pci-sysfs.c would seem like a better place, together with the rest of the resources. Maybe my understanding is incorrect, but given the suggested placement in acpi_pci_irq_enable() I think the device would need to bind the interrupt in order for the gsi node to appear on sysfs? Would the current approach work if the device is assigned to pciback on the kernel command line, and thus never owned by any driver in dom0? > > > >> > >> rc = acpi_register_gsi(&dev->dev, gsi, triggering, polarity); > >> if (rc < 0) { > >> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > >> index 2321fdfefd7d..c51df88d079e 100644 > >> --- a/drivers/pci/pci-sysfs.c > >> +++ b/drivers/pci/pci-sysfs.c > >> @@ -71,6 +71,16 @@ static ssize_t irq_show(struct device *dev, > >> } > >> static DEVICE_ATTR_RO(irq); > >> > >> +static ssize_t gsi_show(struct device *dev, > >> + struct device_attribute *attr, > >> + char *buf) > >> +{ > >> + struct pci_dev *pdev = to_pci_dev(dev); > > > > const > Do you mean "const struct pci_dev *pdev = to_pci_dev(dev);" ? Yup. Thanks, Roger.