From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v1] perf stat: Fix help message for --metric-no-threshold option
Date: Tue, 12 Dec 2023 15:04:43 -0300 [thread overview]
Message-ID: <ZXigu8c0ee0u4uI/@kernel.org> (raw)
In-Reply-To: <CAP-5=fXeZpOg7cHDZmTLvQh=FTamvpdw+=q9vcqrUBd9v7ifLQ@mail.gmail.com>
Em Mon, Dec 11, 2023 at 11:39:02AM -0800, Ian Rogers escreveu:
> On Wed, Nov 29, 2023 at 2:36 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Copy-paste error led to help message for metric-no-threshold repeating
> > that of metric-no-merge.
> >
> > Reported-by: Stephane Eranian <eranian@google.com>
> > Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Ping. Thanks,
> Ian
This is in perf-tools-next now.
- Arnaldo
> > ---
> > tools/perf/builtin-stat.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index a3af805a1d57..c77a3308d3fb 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
> > OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
> > "don't try to share events between metrics in a group"),
> > OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
> > - "don't try to share events between metrics in a group "),
> > + "disable adding events for the metric threshold calculation"),
> > OPT_BOOLEAN(0, "topdown", &topdown_run,
> > "measure top-down statistics"),
> > OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
> > --
> > 2.43.0.rc1.413.gea7ed67945-goog
> >
--
- Arnaldo
prev parent reply other threads:[~2023-12-12 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 22:35 [PATCH v1] perf stat: Fix help message for --metric-no-threshold option Ian Rogers
2023-12-11 19:39 ` Ian Rogers
2023-12-11 21:32 ` Arnaldo Carvalho de Melo
2023-12-12 18:04 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXigu8c0ee0u4uI/@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox