From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7E0C4332F for ; Tue, 12 Dec 2023 18:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377079AbjLLSEo (ORCPT ); Tue, 12 Dec 2023 13:04:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377029AbjLLSEm (ORCPT ); Tue, 12 Dec 2023 13:04:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 487B394 for ; Tue, 12 Dec 2023 10:04:49 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5DBEC433C8; Tue, 12 Dec 2023 18:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702404288; bh=nk//IozMK5UtGAQ/gn7b/tWhhxOCqLkulLRTpbFg1zQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oW+oYDoEzayjqebiyy/C7FhsvKbOlDvGllnGrDnx6jqmjPnx63vvu9RHSIaPJ5qYs pG8djXTEAmorTUJFzOi4mft4v07TwgfHvHEpLX5VDbT/p8QkeFe9EBxWlfzparAUz/ OofwMCMIbZgd88mr/MmmADAaV5bPBadPQGqmPNIRj3D/q7kZVIFPE4BISJUHGOE/Rc LX5MFFEklOfJipYZI70Xyp3s4C5eGMog4vH+VatH1C/g59YmJ+9WZJzKUudmijFU9A ca3Lee5jIqjBhhDuP7mQcUw5LqfPep6MLc1kLL+W/qlOw2pjishkzUQiCODmHQjOLT yNmos7nQPwCwQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id C5850403EF; Tue, 12 Dec 2023 15:04:43 -0300 (-03) Date: Tue, 12 Dec 2023 15:04:43 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v1] perf stat: Fix help message for --metric-no-threshold option Message-ID: References: <20231129223540.2247030-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Dec 11, 2023 at 11:39:02AM -0800, Ian Rogers escreveu: > On Wed, Nov 29, 2023 at 2:36 PM Ian Rogers wrote: > > > > Copy-paste error led to help message for metric-no-threshold repeating > > that of metric-no-merge. > > > > Reported-by: Stephane Eranian > > Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option") > > Signed-off-by: Ian Rogers > > Ping. Thanks, > Ian This is in perf-tools-next now. - Arnaldo > > --- > > tools/perf/builtin-stat.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > > index a3af805a1d57..c77a3308d3fb 100644 > > --- a/tools/perf/builtin-stat.c > > +++ b/tools/perf/builtin-stat.c > > @@ -1255,7 +1255,7 @@ static struct option stat_options[] = { > > OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge, > > "don't try to share events between metrics in a group"), > > OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold, > > - "don't try to share events between metrics in a group "), > > + "disable adding events for the metric threshold calculation"), > > OPT_BOOLEAN(0, "topdown", &topdown_run, > > "measure top-down statistics"), > > OPT_UINTEGER(0, "td-level", &stat_config.topdown_level, > > -- > > 2.43.0.rc1.413.gea7ed67945-goog > > -- - Arnaldo