From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/13] btrfs: factor out block-mapping for RAID0
Date: Wed, 13 Dec 2023 00:50:54 -0800 [thread overview]
Message-ID: <ZXlwbjflk9EwEE7A@infradead.org> (raw)
In-Reply-To: <20231212-btrfs_map_block-cleanup-v1-3-b2d954d9a55b@wdc.com>
> +static void map_blocks_for_raid0(struct btrfs_chunk_map *map,
I'd skip the _for here as it is a bit redundant.
> + enum btrfs_map_op op,
Looking at all the patches: shouldn't the op also go into the
btrfs_io_geometry structure?
next prev parent reply other threads:[~2023-12-13 8:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 12:37 [PATCH 00/13] btrfs: clean up RAID I/O geometry calculation Johannes Thumshirn
2023-12-12 12:37 ` [PATCH 01/13] btrfs: factor out helper for single device IO check Johannes Thumshirn
2023-12-13 8:49 ` Christoph Hellwig
2023-12-12 12:38 ` [PATCH 02/13] btrfs: re-introduce struct btrfs_io_geometry Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 03/13] btrfs: factor out block-mapping for RAID0 Johannes Thumshirn
2023-12-13 8:50 ` Christoph Hellwig [this message]
2023-12-13 9:02 ` Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 04/13] btrfs: factor out RAID1 block mapping Johannes Thumshirn
2023-12-13 8:52 ` Christoph Hellwig
2023-12-12 12:38 ` [PATCH 05/13] btrfs: factor out block mapping for DUP profiles Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 06/13] btrfs: factor out block mapping for RAID10 Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 07/13] btrfs: reduce scope of data_stripes in btrfs_map_block Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 08/13] btrfs: factor out block mapping for RAID5/6 Johannes Thumshirn
2023-12-13 8:53 ` Christoph Hellwig
2023-12-13 9:04 ` Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 09/13] btrfs: factor out block mapping for single profiles Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 10/13] btrfs: untagle if else maze in btrfs_map_block Johannes Thumshirn
2023-12-13 8:53 ` Christoph Hellwig
2023-12-12 12:38 ` [PATCH 11/13] btrfs: open code set_io_stripe for RAID56 Johannes Thumshirn
2023-12-13 8:58 ` Christoph Hellwig
2023-12-13 9:09 ` Johannes Thumshirn
2023-12-13 9:17 ` hch
2023-12-13 9:23 ` Johannes Thumshirn
2023-12-13 15:36 ` Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 12/13] btrfs: pass struct btrfs_io_geometry to set_io_stripe Johannes Thumshirn
2023-12-12 12:38 ` [PATCH 13/13] btrfs: pass btrfs_io_geometry into btrfs_max_io_len Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXlwbjflk9EwEE7A@infradead.org \
--to=hch@infradead.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox