From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2596FC4167D for ; Wed, 13 Dec 2023 15:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442047AbjLMPdw (ORCPT ); Wed, 13 Dec 2023 10:33:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442378AbjLMPdk (ORCPT ); Wed, 13 Dec 2023 10:33:40 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C18293856; Wed, 13 Dec 2023 07:30:55 -0800 (PST) X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="2061516" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="2061516" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 07:28:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="917691498" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="917691498" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 07:28:39 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDRA5-00000005YiE-1JVP; Wed, 13 Dec 2023 17:28:37 +0200 Date: Wed, 13 Dec 2023 17:28:36 +0200 From: Andy Shevchenko To: Kent Gibson Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org Subject: Re: [PATCH 3/4] gpiolib: cdev: reduce locking in gpio_desc_to_lineinfo() Message-ID: References: <20231212054253.50094-1-warthog618@gmail.com> <20231212054253.50094-4-warthog618@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2023 at 11:11:34PM +0800, Kent Gibson wrote: > On Wed, Dec 13, 2023 at 10:07:28PM +0800, Kent Gibson wrote: > > On Wed, Dec 13, 2023 at 03:56:27PM +0200, Andy Shevchenko wrote: > > > On Tue, Dec 12, 2023 at 01:42:52PM +0800, Kent Gibson wrote: ... > > > > - unsigned long flags; > > > > + unsigned long iflags, dflags; > > > > > > With a preliminary conversion to cleanup.h this whole change becomes cleaner, > > > no? > > > > You mean the scoped guards? Dunno - haven't used them. > > Care to provide more detail? > > Ok, so changing the spin_lock/unlock to > > scoped_guard(spinlock_irqsave, &gpio_lock) { > ... > } > > you no longer need the iflags at all, and can rename dflags to flags. Yes, but I prefer still dflags as it is a distinction from the lock flags and we use lflags/dflags a lot in GPIO library, so reading the code will give a hint about the semantics. > Got it. -- With Best Regards, Andy Shevchenko