From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 288F2C4332F
	for <linux-kernel@archiver.kernel.org>; Wed, 13 Dec 2023 16:15:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235457AbjLMQPh (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 13 Dec 2023 11:15:37 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40094 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235450AbjLMQPK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2023 11:15:10 -0500
Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9708128;
        Wed, 13 Dec 2023 08:15:15 -0800 (PST)
Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6ceb93fb381so5228846b3a.0;
        Wed, 13 Dec 2023 08:15:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1702484115; x=1703088915; darn=vger.kernel.org;
        h=in-reply-to:content-transfer-encoding:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date:from:to
         :cc:subject:date:message-id:reply-to;
        bh=yOUUHWkNOhCahFmCbRTrRuCSJdVjqTTZ7BE6QBv4gRw=;
        b=bCrUun2pXb4KlbJLJpLphGoCnowzdXkbMiK1/B2CbzJLA5YyIqykxhAnWL5uypDyll
         mRwjvmPTQFZq2/2Pr2SL6tKRhfkcIZEIEPP+MdkuuzCnZB0nhqEYHGuRC+tRG75iy20g
         3P22X1brI7SvZL4UxXXI7xZaJDeknEe1x+dxnupy8V6CRXPOtd+iFWqydin7gZloiB11
         +N2JZL/m5n96FdrxwbA9Vc9ukfh9fqCZ6T3SEoX3p9QUDEzBib2fPjPvXMsJHhrx5S7L
         CvKRiiT8m6NqLOwOIgOCIbKXMr3Q04bTH1+HnLIcRralnEnRHY6S2tFME4XOblLtULfi
         IJwg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1702484115; x=1703088915;
        h=in-reply-to:content-transfer-encoding:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=yOUUHWkNOhCahFmCbRTrRuCSJdVjqTTZ7BE6QBv4gRw=;
        b=Fbz3WAy/0YVGfAVXyOtedPE0SpAogdm+GeGPEx3b/fNMiRiNv53ycZ5WBLN0lUQRDU
         SRqpY3+9G/p2snnWxR1YFeGXHDvGJBJnPOvv3L/xmNOXY0+wUDUTGUS9xwbNTIs8pmzK
         6wVW21dQdiPFGWCi/KiWgzXZcwaABVTNjXD5yH0yRhHMjdGNg9BJKZ4PJQLMN39qE6Hp
         Ac6QZI+XRFCVx5zd5nTemUblAgZrn+iNaetU4vuvUnfv20sBIH01F9ta9bac42roICdr
         jsEBb6JrGvcfTsxZ5qHlqL0UyRV7kxnLCTCFLs3fQD1+0zn5rZLVI3KHpQOVTxyUDlT1
         Mvwg==
X-Gm-Message-State: AOJu0YyPaOGVCFMllqu/6AGpkMv3xSfQgp6vGlt5viHHt6izQASP3YDK
        j5JCJqu47WPd7qQtUywW8bUoQlO3OBQ=
X-Google-Smtp-Source: AGHT+IHYv019+2GvnGU208A3I2ElJ3H2k/IeYI1PrhyI1RgzmWhySZaaWhpbhpG1z2uKTNbm3nmaYg==
X-Received: by 2002:a05:6a00:189d:b0:6ce:2731:47b8 with SMTP id x29-20020a056a00189d00b006ce273147b8mr11025494pfh.24.1702484114891;
        Wed, 13 Dec 2023 08:15:14 -0800 (PST)
Received: from rigel (194-223-186-106.tpgi.com.au. [194.223.186.106])
        by smtp.gmail.com with ESMTPSA id x11-20020a056a00270b00b006ce7e65159bsm10127487pfv.28.2023.12.13.08.15.12
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 13 Dec 2023 08:15:14 -0800 (PST)
Date:   Thu, 14 Dec 2023 00:15:10 +0800
From:   Kent Gibson <warthog618@gmail.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Andy Shevchenko <andy@kernel.org>, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH 1/4] gpiolib: cdev: relocate debounce_period_us from
 struct gpio_desc
Message-ID: <ZXnYjoXHGiar-hvJ@rigel>
References: <20231212054253.50094-1-warthog618@gmail.com>
 <20231212054253.50094-2-warthog618@gmail.com>
 <ZXm3rayrcvfO1t1Z@smile.fi.intel.com>
 <ZXm_WsIpgIyOUNHt@rigel>
 <CAMRc=Mfri8K4ZqcHb_eQY6gi+q_-uBZc2wiMrrb-+a7Tric3FA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMRc=Mfri8K4ZqcHb_eQY6gi+q_-uBZc2wiMrrb-+a7Tric3FA@mail.gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 13, 2023 at 04:40:12PM +0100, Bartosz Golaszewski wrote:
> On Wed, Dec 13, 2023 at 3:27 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
>
> > >
> > > > +out_unlock:
> > > > +   spin_unlock(&supinfo.lock);
> > >
> > > No use of cleanup.h?
> > >
> >
> > Again, that is new to me, so no not yet.
> >
>
> Yep, please use a guard, they're awesome. :)
>

Before I go nuts and switch everything over, is it ok to put a return
within the scoped_guard - it will automatically unlock on the way out?

Cheers,
Kent.