From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C88EC4332F for ; Wed, 13 Dec 2023 16:55:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233311AbjLMQzc (ORCPT ); Wed, 13 Dec 2023 11:55:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233248AbjLMQza (ORCPT ); Wed, 13 Dec 2023 11:55:30 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6AAAC for ; Wed, 13 Dec 2023 08:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6C+G+He17NccpRYXyvfr/RRpub5+8DDVn1CdeNstsjM=; b=eMShkFmEwwZe5F929p52bl4FOD CvbkWqFICiRnUUQ1L//RWI2/P+5TDUv56GmEj4i+95Nj9pWhwp/2RoOLS0MxofbBB4waUmwKHwaHN LwsuQ5EtxnSmzd04hX7iyhhjz252+MtHuP1bq512XRDW+lIkoqFAwRZi+v1H+hgV5ldaKBzUxpDuz KEXf2wwntJZbJtQhnH85vu/dp4kfYJqSvdPYD0jN/DShb1Nr8aEzy5/ITthEmGObyXHmJjR6RlMi2 GSZyllH0Swb0VsZ/MWVlpCb+puMSougMmcBgJyQb7yqH3NA5tL6iYP6RHmFQ9Tt0H64UUxeHpNEfz GCJfbewQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDSWB-00FWGw-0R; Wed, 13 Dec 2023 16:55:31 +0000 Date: Wed, 13 Dec 2023 08:55:31 -0800 From: Christoph Hellwig To: Saeed Mahameed Cc: Aron Silverton , Jakub Kicinski , Greg Kroah-Hartman , Jason Gunthorpe , David Ahern , Arnd Bergmann , Leon Romanovsky , Jiri Pirko , Leonid Bloch , Itay Avraham , linux-kernel@vger.kernel.org, Saeed Mahameed Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Message-ID: References: <20231128175224.GR436702@nvidia.com> <20231128103304.25c2c642@kernel.org> <2023112922-lyricist-unclip-8e78@gregkh> <20231204185210.030a72ca@kernel.org> <20231205204855.52fa5cc1@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 07, 2023 at 10:54:02AM -0800, Saeed Mahameed wrote: > Also I would like to repeat, this is not touching netdev, netdev's policies > do not apply to the greater kernel or RDMA, and we have use cases with > pure-infiniband/DPU/FPGA cards that have no netdev at all, or other cases > with pur virtio instances, and much more. Yes. I mean just about every complex block driver has some kind of vendor spcific tooling for debugging, statistics, etc. Trying to deny it just because one function expose by a device is a network device is even more silly than disallowing it for pure net devices (which already tend to be complex beasts).