From: Mike Snitzer <snitzer@kernel.org>
To: Hongyu Jin <hongyu.jin.cn@gmail.com>
Cc: agk@redhat.com, mpatocka@redhat.com, axboe@kernel.dk,
ebiggers@kernel.org, zhiguo.niu@unisoc.com, ke.wang@unisoc.com,
yibin.ding@unisoc.com, hongyu.jin@unisoc.com,
linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
linux-block@vger.kernel.org
Subject: Re: [PATCH v5 1/5] block: Fix bio IO priority setting
Date: Wed, 13 Dec 2023 11:58:23 -0500 [thread overview]
Message-ID: <ZXnir8x6127EW7Gp@redhat.com> (raw)
In-Reply-To: <20231213104216.27845-2-hongyu.jin.cn@gmail.com>
On Wed, Dec 13 2023 at 5:42P -0500,
Hongyu Jin <hongyu.jin.cn@gmail.com> wrote:
> From: Hongyu Jin <hongyu.jin@unisoc.com>
>
> Move bio_set_ioprio() into submit_bio():
> 1. Only call bio_set_ioprio() once to set the priority of original bio,
> the bio that cloned and splited from original bio will auto inherit
> the priority of original bio in clone process.
>
> 2. The IO priority can be passed to module that implement
> struct gendisk::fops::submit_bio, help resolve some
> of the IO priority loss issues.
>
> This patch depends on commit 82b74cac2849 ("blk-ioprio: Convert from
> rqos policy to direct call")
>
> Fixes: a78418e6a04c ("block: Always initialize bio IO priority on submit")
>
> Co-developed-by: Yibin Ding <yibin.ding@unisoc.com>
> Signed-off-by: Yibin Ding <yibin.ding@unisoc.com>
> Signed-off-by: Hongyu Jin <hongyu.jin@unisoc.com>
Would be nice to get this block core fix upstream ASAP independent of
your various DM changes.
Please simplify this patch's header like was requested in review of v4:
https://patchwork.kernel.org/project/dm-devel/patch/20231212111150.18155-2-hongyu.jin.cn@gmail.com/
next prev parent reply other threads:[~2023-12-13 17:42 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 9:44 [PATCH] dm: increase the io priority of the kworker-kverityd process Yunlong Xing
2023-11-28 14:07 ` Mikulas Patocka
2023-12-06 11:39 ` [PATCH v2] dm verity: Inherit I/O priority from data I/O when read FEC and hash from disk Hongyu Jin
2023-12-08 1:54 ` Eric Biggers
2023-12-08 20:34 ` Eric Wheeler
2023-12-11 8:59 ` [PATCH v3 0/5] Fix I/O priority lost in device-mapper Hongyu Jin
2023-12-11 8:59 ` [PATCH v3 1/5] block: Optimize bio io priority setting Hongyu Jin
2023-12-11 21:12 ` Mike Snitzer
2023-12-11 8:59 ` [PATCH v3 2/5] dm: Support I/O priority for dm_io() Hongyu Jin
2023-12-11 8:59 ` [PATCH v3 3/5] dm-bufio: Support I/O priority Hongyu Jin
2023-12-11 8:59 ` [PATCH v3 4/5] dm verity: Fix I/O priority lost when read FEC and hash Hongyu Jin
2023-12-11 9:00 ` [PATCH v3 5/5] dm-crypt: Fix lost ioprio when queuing write bios Hongyu Jin
2023-12-11 20:32 ` Eric Wheeler
2023-12-11 22:15 ` Mike Snitzer
2023-12-12 11:11 ` [PATCH v4 0/5] Fix I/O priority lost in device-mapper Hongyu Jin
2023-12-12 11:11 ` [PATCH v4 1/5] block: Fix bio IO priority setting Hongyu Jin
2023-12-12 13:13 ` Christoph Hellwig
2023-12-12 18:02 ` Mike Snitzer
2023-12-12 11:11 ` [PATCH v4 2/5] dm: Support I/O priority for dm_io() Hongyu Jin
2023-12-13 4:57 ` Eric Biggers
2023-12-12 11:11 ` [PATCH v4 3/5] dm-bufio: Support I/O priority Hongyu Jin
2023-12-13 5:00 ` Eric Biggers
2023-12-12 11:11 ` [PATCH v4 4/5] dm verity: Fix I/O priority lost when read FEC and hash Hongyu Jin
2023-12-12 11:11 ` [PATCH v4 5/5] dm-crypt: Fix lost ioprio when queuing write bios Hongyu Jin
2023-12-13 4:45 ` [PATCH v4 0/5] Fix I/O priority lost in device-mapper Eric Biggers
2023-12-13 9:24 ` Henry King
2023-12-13 10:42 ` Hongyu Jin
2023-12-13 10:42 ` [PATCH v5 1/5] block: Fix bio IO priority setting Hongyu Jin
2023-12-13 16:58 ` Mike Snitzer [this message]
2023-12-18 1:24 ` Henry King
2023-12-18 1:27 ` [PATCH v5 RESEND 0/5] Fix I/O priority lost in device-mapper Hongyu Jin
2023-12-18 1:27 ` [PATCH v5 RESEND 1/5] block: Fix bio IO priority setting Hongyu Jin
2023-12-18 1:27 ` [PATCH v5 RESEND 2/5] dm: Support I/O priority for dm_io() Hongyu Jin
2023-12-19 22:46 ` Eric Biggers
2023-12-18 1:27 ` [PATCH v5 RESEND 3/5] dm-bufio: Support I/O priority Hongyu Jin
2023-12-19 22:46 ` Eric Biggers
2023-12-18 1:27 ` [PATCH v5 RESEND 4/5] dm verity: Fix I/O priority lost when read FEC and hash Hongyu Jin
2023-12-19 22:48 ` Eric Biggers
2023-12-20 1:14 ` Hongyu Jin
2023-12-18 1:27 ` [PATCH v5 RESEND 5/5] dm-crypt: Fix lost ioprio when queuing write bios Hongyu Jin
2023-12-19 22:50 ` Eric Biggers
2023-12-19 0:46 ` [PATCH v5 RESEND 0/5] Fix I/O priority lost in device-mapper Eric Biggers
2023-12-13 10:42 ` [PATCH v5 2/5] dm: Support I/O priority for dm_io() Hongyu Jin
2023-12-13 10:42 ` [PATCH v5 3/5] dm-bufio: Support I/O priority Hongyu Jin
2023-12-13 10:42 ` [PATCH v5 4/5] dm verity: Fix I/O priority lost when read FEC and hash Hongyu Jin
2023-12-13 10:42 ` [PATCH v5 5/5] dm-crypt: Fix lost ioprio when queuing write bios Hongyu Jin
2023-12-20 10:03 ` [PATCH v6 0/5] Fix I/O priority lost in device-mapper Hongyu Jin
2023-12-20 10:03 ` [PATCH v6 1/5] block: Fix bio IO priority setting Hongyu Jin
2023-12-20 10:03 ` [PATCH v6 2/5] dm: Support I/O priority for dm_io() Hongyu Jin
2023-12-20 10:03 ` [PATCH v6 3/5] dm-bufio: Support I/O priority Hongyu Jin
2023-12-20 10:03 ` [PATCH v6 4/5] dm verity: Fix I/O priority lost when read FEC and hash Hongyu Jin
2023-12-20 18:32 ` Eric Biggers
2023-12-20 10:03 ` [PATCH v6 5/5] dm-crypt: Fix lost ioprio when queuing write bios Hongyu Jin
2023-12-21 10:31 ` [PATCH v7 0/5] Fix I/O priority lost in device-mapper Hongyu Jin
2023-12-21 10:31 ` [PATCH v7 1/5] block: Fix bio IO priority setting Hongyu Jin
2023-12-21 10:31 ` [PATCH v7 2/5] dm: Support I/O priority for dm_io() Hongyu Jin
2023-12-21 10:31 ` [PATCH v7 3/5] dm-bufio: Support I/O priority Hongyu Jin
2023-12-21 10:31 ` [PATCH v7 4/5] dm verity: Fix I/O priority lost when read FEC and hash Hongyu Jin
2023-12-21 10:31 ` [PATCH v7 5/5] dm-crypt: Fix lost ioprio when queuing write bios Hongyu Jin
2024-01-24 5:35 ` [PATCH v8 0/5] Fix I/O priority lost in device-mapper Hongyu Jin
2024-01-24 5:35 ` [PATCH v8 1/5] block: Fix bio IO priority setting Hongyu Jin
2024-01-24 5:35 ` [PATCH v8 2/5] dm: Support I/O priority for dm_io() Hongyu Jin
2024-01-24 5:35 ` [PATCH v8 3/5] dm-bufio: Support I/O priority Hongyu Jin
2024-01-24 5:35 ` [PATCH v8 4/5] dm verity: Fix I/O priority lost when read FEC and hash Hongyu Jin
2024-01-24 5:35 ` [PATCH v8 5/5] dm-crypt: Fix lost ioprio when queuing write bios Hongyu Jin
2024-01-29 16:30 ` [PATCH v8 0/5] Fix I/O priority lost in device-mapper Mike Snitzer
2024-01-29 19:29 ` Mikulas Patocka
2023-12-23 15:41 ` [PATCH v7 " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXnir8x6127EW7Gp@redhat.com \
--to=snitzer@kernel.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=hongyu.jin.cn@gmail.com \
--cc=hongyu.jin@unisoc.com \
--cc=ke.wang@unisoc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=yibin.ding@unisoc.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox