From: Juri Lelli <juri.lelli@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Aaron Tomlin <atomlin@atomlin.com>,
linux-kernel@vger.kernel.org, jiangshanlai@gmail.com,
peterz@infradead.org
Subject: Re: [RFC PATCH 0/2] workqueue: Introduce PF_WQ_RESCUE_WORKER
Date: Thu, 14 Dec 2023 12:25:25 +0100 [thread overview]
Message-ID: <ZXrmJYvekzrLSaGo@localhost.localdomain> (raw)
In-Reply-To: <ZXn6J5bN-dPC1WSk@slm.duckdns.org>
On 13/12/23 08:38, Tejun Heo wrote:
> On Wed, Dec 13, 2023 at 07:32:10PM +0100, Juri Lelli wrote:
> > > Maybe the easiest way to do this is making rescuer_thread() restore the wq's
> > > cpumask right before going to sleep, and making apply_wqattrs_commit() just
> > > wake up the rescuer.
> >
> > Hummm, don't think we can call that either while the rescuer is actually
> > running. Maybe we can simply s/kthread_bind_mask/set_cpus_allowed_ptr/
> > in the above?
>
> So, we have to use set_cpus_allowed_ptr() but we still don't want to change
> the affinity of a rescuer which is already running a task for a pool.
But then, even today, a rescuer might keep handling work on a cpu
outside its wq cpumask if the associated wq cpumask change can proceed
w/o waiting for it to finish the iteration?
BTW, apologies for all the questions, but I'd like to make sure I can
get the implications hopefully right. :)
Thanks,
Juri
next prev parent reply other threads:[~2023-12-14 11:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 13:53 [RFC PATCH 0/2] workqueue: Introduce PF_WQ_RESCUE_WORKER Aaron Tomlin
2023-07-29 13:53 ` [RFC PATCH 1/2] " Aaron Tomlin
2023-07-29 16:07 ` Peter Zijlstra
2023-08-01 10:04 ` Aaron Tomlin
2023-07-29 13:53 ` [RFC PATCH 2/2] workqueue: Simplify current_is_workqueue_rescuer() Aaron Tomlin
2023-07-31 23:35 ` [RFC PATCH 0/2] workqueue: Introduce PF_WQ_RESCUE_WORKER Tejun Heo
2023-08-01 10:53 ` Aaron Tomlin
2023-08-02 18:10 ` Tejun Heo
2023-08-03 20:19 ` Aaron Tomlin
2023-08-03 20:34 ` Tejun Heo
2023-08-05 23:45 ` Aaron Tomlin
2023-12-11 14:51 ` Juri Lelli
2023-12-11 18:39 ` Tejun Heo
2023-12-12 9:56 ` Juri Lelli
2023-12-12 17:14 ` Tejun Heo
2023-12-12 19:06 ` Aaron Tomlin
2023-12-12 20:16 ` Tejun Heo
2023-12-13 8:59 ` Juri Lelli
2023-12-13 15:35 ` Tejun Heo
2023-12-13 18:32 ` Juri Lelli
2023-12-13 18:38 ` Tejun Heo
2023-12-14 11:25 ` Juri Lelli [this message]
2023-12-14 19:47 ` Tejun Heo
2023-12-15 6:50 ` Juri Lelli
2023-12-19 8:55 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXrmJYvekzrLSaGo@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=atomlin@atomlin.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox