From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B459DC4332F for ; Thu, 14 Dec 2023 13:07:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573216AbjLNNH0 (ORCPT ); Thu, 14 Dec 2023 08:07:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573195AbjLNNHY (ORCPT ); Thu, 14 Dec 2023 08:07:24 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37BA2125 for ; Thu, 14 Dec 2023 05:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702559251; x=1734095251; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0x0dcNmUg6lcvmK7wm/BxdaspNCXdhIjGhhzUdfcO1o=; b=FK3kleeqkux4QSLFI/QXJ2FBEvW5hSiJ7M4wuAQ/ozOgoOaiQOb3h2UF Nkij5qEEIx8Co9qqelNFsmAcsjUTRAg4pG4Xeiib9GQ2oMhT9MudSjgJ4 wKeRW2ibodZB4ehzfiOOJFyyFKWNf9TGMkCi/nWJXJNSoszGGbZvoNvtf +xwUyRxFe94L8ZBXbDatDzcMIcLk4KYPXQKfEjnopwxjorr363c2f+nKm 0HSfkiy8GeDmcBgQ5RBk5mYlJfhYp/0OON86eCvnkzq0M/zLBwGZBhbGB Uk002L+P2zbu59YnJ9622P7na+t0xV08+iZMKkrd/4HWaXVJxv99EoQ1O Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1935255" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="1935255" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 05:07:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="22400926" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by orviesa001.jf.intel.com with ESMTP; 14 Dec 2023 05:07:07 -0800 Date: Thu, 14 Dec 2023 21:19:30 +0800 From: Zhao Liu To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Ira Weiny , "Fabio M . De Francesco" , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Dave Hansen , Zhenyu Wang , Zhao Liu Subject: Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page() Message-ID: References: <20231203132947.2328805-1-zhao1.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231203132947.2328805-1-zhao1.liu@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi maintainers, Just kindly ping. May I ask if this refresh version could be merged into the next tree of the i915? Thanks, Zhao On Sun, Dec 03, 2023 at 09:29:38PM +0800, Zhao Liu wrote: > Date: Sun, 3 Dec 2023 21:29:38 +0800 > From: Zhao Liu > Subject: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with > kmap_local_page() > X-Mailer: git-send-email 2.34.1 > > From: Zhao Liu > > Hi all, > > I refreshed this v3 by rebasing v2 [1] on the commit 968f35f4ab1c > ("Merge tag 'v6.7-rc3-smb3-client-fixes' of git://git.samba.org/sfrench/ > cifs-2.6"). > > Based on the current code, I rechecked the substitutions in v2 and they > still stand and are valid, so no code change in v3. > > Thanks for all the review! And sorry v2 was missed, I'll pay more > attention to this v3. > > > Purpose of This Patchset > ======================== > > The purpose of this pacthset is to replace all uses of kmap_atomic() in > i915 with kmap_local_page() because the use of kmap_atomic() is being > deprecated in favor of kmap_local_page()[2]. And 92b64bd (mm/highmem: > add notes about conversions from kmap{,_atomic}()) has declared the > deprecation of kmap_atomic(). > > > Motivation for Deprecating kmap_atomic() and Using kmap_local_page() > ==================================================================== > > The main difference between atomic and local mappings is that local > mappings doesn't disable page faults or preemption (the preemption is > disabled for !PREEMPT_RT case, otherwise it only disables migration). > > With kmap_local_page(), we can avoid the often unwanted side effect of > unnecessary page faults and preemption disables. > > > Patch summary > ============= > > Patch 1, 4-6 and 8-9 replace kmap_atomic()/kunmap_atomic() with > kmap_local_page()/kunmap_local() directly. With these local > mappings, the page faults and preemption are allowed. > > Patch 2 and 7 use memcpy_from_page() and memcpy_to_page() to replace > kmap_atomic()/kunmap_atomic(). These two variants of memcpy() > are based on the local mapping, so page faults and preemption > are also allowed in these two interfaces. > > Patch 3 replaces kmap_atomic()/kunmap_atomic() with kmap_local_page()/ > kunmap_local() and also disable page fault since the for special > handling (pls see the commit message). > > > Reference > ========= > > [1]: https://lore.kernel.org/all/20230329073220.3982460-1-zhao1.liu@linux.intel.com/ > [2]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com > > > Thanks and Best Regards, > Zhao > > --- > Changlog: > > Changes since v2: > * Rebased on 968f35f4ab1c ("Merge tag 'v6.7-rc3-smb3-client-fixes' of > git://git.samba.org/sfrench/cifs-2.6"). > * Removed changelog (of v2) in commit message. > * Fixed typo in cover letter (Fabio). > * Added Reviewed-by tags from Ira and Fabio. > > Changes since v1: > * Dropped hot plug related description in commit message since it has > nothing to do with kmap_local_page(). > * Emphasized the motivation for using kmap_local_page() in commit > message. > * Rebased patch 1 on f47e630 (drm/i915/gem: Typecheck page lookups) to > keep the "idx" variable of type pgoff_t here. > * Used memcpy_from_page() and memcpy_to_page() to replace > kmap_local_page() + memcpy() in patch 2. > > --- > Zhao Liu (9): > drm/i915: Use kmap_local_page() in gem/i915_gem_object.c > drm/i915: Use memcpy_[from/to]_page() in gem/i915_gem_pyhs.c > drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c > drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c > drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c > drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c > drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c > drm/i915: Use kmap_local_page() in i915_cmd_parser.c > drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 10 +++++----- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 8 +++----- > drivers/gpu/drm/i915/gem/i915_gem_phys.c | 10 ++-------- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++++-- > drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 6 +++--- > .../gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 12 ++++-------- > .../gpu/drm/i915/gem/selftests/i915_gem_context.c | 8 ++++---- > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 5 +---- > drivers/gpu/drm/i915/i915_cmd_parser.c | 4 ++-- > 9 files changed, 28 insertions(+), 41 deletions(-) > > -- > 2.34.1 >