From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF418C4332F for ; Thu, 14 Dec 2023 14:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573590AbjLNOx5 (ORCPT ); Thu, 14 Dec 2023 09:53:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573569AbjLNOxx (ORCPT ); Thu, 14 Dec 2023 09:53:53 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8A2115; Thu, 14 Dec 2023 06:54:00 -0800 (PST) X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="2288527" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="2288527" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 06:54:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="897768677" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="897768677" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 06:53:58 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDn63-00000005s6R-0Z65; Thu, 14 Dec 2023 16:53:55 +0200 Date: Thu, 14 Dec 2023 16:53:54 +0200 From: Andy Shevchenko To: Kent Gibson Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org Subject: Re: [PATCH v2 1/5] gpiolib: cdev: adopt scoped_guard() Message-ID: References: <20231214095814.132400-1-warthog618@gmail.com> <20231214095814.132400-2-warthog618@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 14, 2023 at 07:50:44PM +0800, Kent Gibson wrote: > On Thu, Dec 14, 2023 at 05:58:10PM +0800, Kent Gibson wrote: > > Use scoped_guard for critical sections rather than distinct > > lock/unlock pairs. > > It seems using guard() can further simplify cases where the scope extends > to the end of the function, so I'll replace those cases when I do v3. Ah, we are on the same page here! -- With Best Regards, Andy Shevchenko