From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14252C4332F for ; Thu, 14 Dec 2023 15:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573615AbjLNPDD (ORCPT ); Thu, 14 Dec 2023 10:03:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573588AbjLNPDC (ORCPT ); Thu, 14 Dec 2023 10:03:02 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B57E115; Thu, 14 Dec 2023 07:03:09 -0800 (PST) X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="375285976" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="375285976" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 07:03:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="750560273" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="750560273" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 07:03:06 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDnEt-00000005sDd-1JJ6; Thu, 14 Dec 2023 17:03:03 +0200 Date: Thu, 14 Dec 2023 17:03:03 +0200 From: Andy Shevchenko To: Kent Gibson Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org Subject: Re: [PATCH v2 2/5] gpiolib: cdev: relocate debounce_period_us from struct gpio_desc Message-ID: References: <20231214095814.132400-1-warthog618@gmail.com> <20231214095814.132400-3-warthog618@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214095814.132400-3-warthog618@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 14, 2023 at 05:58:11PM +0800, Kent Gibson wrote: > Store the debounce period for a requested line locally, rather than in > the debounce_period_us field in the gpiolib struct gpio_desc. > > Add a global tree of lines containing supplemental line information > to make the debounce period available to be reported by the > GPIO_V2_GET_LINEINFO_IOCTL and the line change notifier. ... > +/* > + * Used to populate gpio_v2_line_info with cdev specific fields not contained > + * in the struct gpio_desc. > + * A line is determined to contain supplemental information by > + * line_is_supplemental(). > + */ > +static struct { > + /* a rbtree of the struct lines containing the supplemental info */ > + struct rb_root tree; > + /* covers tree */ > + spinlock_t lock; > +} supinfo; ... > +static void supinfo_init(void) > +{ > + supinfo.tree = RB_ROOT; > + spin_lock_init(&supinfo.lock); > +} Can it be done statically? supinfo = { .tree = RB_ROOT, .lock = __SPIN_LOCK_UNLOCKED(supinfo.lock), }; ... > +static int __init gpiolib_cdev_init(void) > +{ > + supinfo_init(); > + return 0; > +} A comment why it's postcore initcall? /* postcore initcall is chosen because ... */ > +postcore_initcall(gpiolib_cdev_init); -- With Best Regards, Andy Shevchenko