From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Add Intel Meteor Point pin controller and GPIO support
Date: Fri, 15 Dec 2023 16:42:31 +0200 [thread overview]
Message-ID: <ZXxl161aJ8vZyiPw@smile.fi.intel.com> (raw)
In-Reply-To: <20231215064417.GV1074920@black.fi.intel.com>
On Fri, Dec 15, 2023 at 08:44:17AM +0200, Mika Westerberg wrote:
> On Thu, Dec 14, 2023 at 05:46:53PM +0200, Andy Shevchenko wrote:
> > This driver supports pinctrl/GPIO hardware found on Intel Meteor Point
> > (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces
> > including GPIO interrupts.
>
> This is driver for Meteor Lake-S and related, correct? Why it cannot use
> pinctrl-meteorlake.c instead? Same way we do for other desktop CPUs
> whose PCHs have the GPIO/pinctrl block.
Meteor Lake-S may or may not have an additional PCH, so the SoC (on-die)
pin control IP is serviced by pinctrl-meteorlake.c, here we need to have
a different file as we would have a name clash. Yes, it means that on
the end user platform it may be two pin control drivers!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-15 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 15:46 [PATCH v1 1/1] pinctrl: intel: Add Intel Meteor Point pin controller and GPIO support Andy Shevchenko
2023-12-15 6:44 ` Mika Westerberg
2023-12-15 14:42 ` Andy Shevchenko [this message]
2023-12-15 14:58 ` Mika Westerberg
2023-12-15 15:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXxl161aJ8vZyiPw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox