Re: [PATCH v3 3/5] gpiolib: cdev: reduce locking in gpio_desc_to_lineinfo()

Kent Gibson
2023-12-15T23:27:26Z

On Fri, Dec 15, 2023 at 06:36:23PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 15, 2023 at 10:38:03AM +0800, Kent Gibson wrote:
> > Reduce the time holding the gpio_lock by snapshotting the desc flags,
> > rather than testing them individually while holding the lock.
> >
> > Accept that the calculation of the used field is inherently racy, and
> > only check the availability of the line from pinctrl if other checks
> > pass, so avoiding the check for lines that are otherwise in use.
>
> Just wondering if you are using --histogram (diff algo) when preparing
> the patches...
>

Was just using the default myers.
Only changes patch 4, which it does make slightly more readable, so
will use it for v4.

Cheers,
Kent.