From: William Breathitt Gray <william.gray@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] counter: linux/counter.h: fix Excess kernel-doc description warning
Date: Thu, 28 Dec 2023 09:46:57 -0500 [thread overview]
Message-ID: <ZY2KYemBCrl7YwrP@ishi> (raw)
In-Reply-To: <d752d157-659b-4d05-90a9-ebbf19c07068@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]
On Wed, Dec 27, 2023 at 01:40:01PM -0800, Randy Dunlap wrote:
>
>
> On 12/27/23 06:35, William Breathitt Gray wrote:
> > On Fri, Dec 22, 2023 at 09:05:11PM -0800, Randy Dunlap wrote:
> >> Remove the @priv: line to prevent the kernel-doc warning:
> >>
> >> include/linux/counter.h:400: warning: Excess struct member 'priv' description in 'counter_device'
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Cc: William Breathitt Gray <william.gray@linaro.org>
> >> Cc: linux-iio@vger.kernel.org
> >> ---
> >> include/linux/counter.h | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff -- a/include/linux/counter.h b/include/linux/counter.h
> >> --- a/include/linux/counter.h
> >> +++ b/include/linux/counter.h
> >> @@ -359,7 +359,6 @@ struct counter_ops {
> >> * @num_counts: number of Counts specified in @counts
> >> * @ext: optional array of Counter device extensions
> >> * @num_ext: number of Counter device extensions specified in @ext
> >> - * @priv: optional private data supplied by driver
> >> * @dev: internal device structure
> >> * @chrdev: internal character device structure
> >> * @events_list: list of current watching Counter events
> >
> > Hi Randy,
> >
> > Would you provide a Fixes tag for the commit that removed the 'priv'
> > member so we can track when this warning appeared? You can respond with
> > it to this thread and I'll add it in when I merge your patch.
>
> Fixes: f2ee4759fb70 ("counter: remove old and now unused registration API")
>
> Thank you.
>
> --
> #Randy
Applied, thanks!
[1/1] counter: linux/counter.h: fix Excess kernel-doc description warning
commit: 49ca40f8d6ceb76bff83713f79215d8e6252f045
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-12-28 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 5:05 [PATCH] counter: linux/counter.h: fix Excess kernel-doc description warning Randy Dunlap
2023-12-27 14:35 ` William Breathitt Gray
2023-12-27 21:40 ` Randy Dunlap
2023-12-28 14:46 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZY2KYemBCrl7YwrP@ishi \
--to=william.gray@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox