From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wxsgout04.xfusion.com (wxsgout03.xfusion.com [36.139.52.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F203D199B2 for ; Mon, 18 Dec 2023 12:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=xfusion.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xfusion.com Received: from wuxshcsitd00600.xfusion.com (unknown [10.32.133.213]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4Stzkc708yz9xn3d; Mon, 18 Dec 2023 20:33:12 +0800 (CST) Received: from localhost (10.82.147.3) by wuxshcsitd00600.xfusion.com (10.32.133.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 18 Dec 2023 20:36:39 +0800 Date: Mon, 18 Dec 2023 20:36:38 +0800 From: Wang Jinchao To: Sohil Mehta CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , , Subject: Re: [PATCH] x86/setup: remove duplicated including Message-ID: References: <202312151755+0800-wangjinchao@xfusion.com> <16028dde-261a-4403-8165-f0a8b70f13fa@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <16028dde-261a-4403-8165-f0a8b70f13fa@intel.com> X-ClientProxiedBy: wuxshcsitd00602.xfusion.com (10.32.132.250) To wuxshcsitd00600.xfusion.com (10.32.133.213) On Mon, Dec 18, 2023 at 05:27:46PM +0530, Sohil Mehta wrote: > How about rewording the above to? > > "x86/setup: Remove duplicate header includes" > > On 12/15/2023 3:25 PM, Wang Jinchao wrote: > > rm the second #include in setup.c > > > rm the second #include in smpboot.c > > Actually, these two lines are evident from the diff itself. You can > remove both of them. If you really want to have some text in the commit > message you can probably just say: > > efi.h and spec-ctrl.h are included twice. Remove the duplicate entries. > > > > > Signed-off-by: Wang Jinchao > > --- > > arch/x86/kernel/setup.c | 1 - > > arch/x86/kernel/smpboot.c | 1 - > > 2 files changed, 2 deletions(-) > > > > With the above changes, please feel free to add: > > Reviewed-by: Sohil Mehta > Thanks for the suggestion, which has been applied to the v2 patch.