From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E14538F81; Wed, 20 Dec 2023 14:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PTc1MRG9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703081357; x=1734617357; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=4aqkzWwe/QO/2csYRmPX92UHytd6d0JQX8zFr1gOUuM=; b=PTc1MRG9rnhTyocnVPG42JUdF0yZFJfrzED3bLMoZ+j8sxz/XZ2TPuFY VrLVpki8E4Ap3muFgY5c4Ha1Y7dsCDk9byXdvsBBA5aHZtMoIclf1CwS2 o9i0fxSE5W7JBg9CknC5B/YktQ9cRRMJfRYAIqQmNf61aCoq9LoFZmReq N7shGrP8Ec1c4dxrlJB4XXCuvrKqdWTwIbFGCOU6BK0Q52Rpd7husBpVa 4oDTBcFFBQndP08xIzUfiuTRSbZl3CKVNu75fvKrioqVYxFomaogdExFW NagcyGJyz/bCOQLjnLlkpP8RHmrXipY1ODSl5o8IZOaRUaBstM/x9GcM2 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="2658126" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="2658126" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 06:09:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="779862813" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="779862813" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 06:09:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rFxG3-00000007YP4-3Lkx; Wed, 20 Dec 2023 16:09:11 +0200 Date: Wed, 20 Dec 2023 16:09:11 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Kent Gibson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 1/2] gpiolib: drop tabs from local variable declarations Message-ID: References: <20231219142323.28929-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Dec 19, 2023 at 08:59:12PM +0100, Bartosz Golaszewski wrote: > On Tue, Dec 19, 2023 at 4:06 PM Andy Shevchenko > wrote: > > On Tue, Dec 19, 2023 at 03:23:22PM +0100, Bartosz Golaszewski wrote: ... > > > + struct gpio_chip *gc = desc->gdev->chip; > > > + int ret; > > > + unsigned long flags; > > > + unsigned int offset; > > > > I'm wondering if you can make it reversed xmas tree order. > > This will make it even more consistent between functions. > > Sure but we'd have to update all functions across gpiolib.c. Let's > take it one thing at a time. The point is to do this for the lines you modified to avoid additional churn and burden for backport. At least these two things (removing TABs and shuffling the order) are kinda of the same family of the logical changes. I do not see the problem doing this in one patch for the lines you modified. Yet, for the rest it might be another patch, but I don't think it worth doing it. -- With Best Regards, Andy Shevchenko