Re: [PATCH 4/4] gpiolib: cdev: replace locking wrappers for gpio_device with guards

Linus Walleij
2023-12-20T11:56:02Z

(+PeterZ)

On Wed, Dec 20, 2023 at 2:52 AM Kent Gibson <warthog618@gmail.com> wrote:

> Replace the wrapping functions that inhibit removal of the gpio_device
> with equivalent guard macros.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
(...)
> +DEFINE_CLASS(_read_sem_guard,
> + struct rw_semaphore *,
> + up_read(_T),
> + ({
> + down_read(sem);
> + sem;
> + }),
> + struct rw_semaphore *sem);

Isn't this so generic that it should be in <linux/cleanup.h>?

Otherwise all the patches look good to me.

Yours,
Linus Walleij