Re: [PATCH 1/2] perf archive: Add new option '--all'

Re: [PATCH 1/2] perf archive: Add new option '--all'

[Arnaldo Carvalho de Melo]

Em Tue, Dec 12, 2023 at 03:06:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Dec 12, 2023 at 05:59:08PM +0100, vmolnaro@redhat.com escreveu:
> > From: Veronika Molnarova <vmolnaro@redhat.com>
> > 
> > Perf archive has limited functionality and people from Red Hat Global
> > Support Services sent a request for a new feature that would pack
> > perf.data file together with an archive with debug symbols created by
> > the command 'perf archive' as customers were being confused and often
> > would forget to send perf.data file with the debug symbols.
> > 
> > Perf archive now accepts an option '--all' that generates archive
> > 'perf.all-hostname-date-time.tar.bz2' that holds file 'perf.data' and
> > a sub-tar 'perf.symbols.tar.bz2' with debug symbols. The functionality of
> > the command 'perf archive' was not changed.
> 
> Thanks for working on this, I'll do some testing and apply, probably
> tomorrow.

I applied it, tested by doing a 'perf record' on an hybrid Intel Machine
(14700k) and then using --unpack on an hybrid ARM64 machine (rk3399-pc),
all working as expected:

https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=tmp.perf-tools-next&id=624dda101e03c3a3a155d51e37a7bb7607cb760b

Some suggestions for further improvements:

acme@roc-rk3399-pc:~$ perf archive --unpack
Found target file for unpacking: ./perf.all-number-20231219-104854.tar.bz2
perf.data
perf.symbols.tar.bz2
tar: /home/acme/.debug: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
acme@roc-rk3399-pc:~$

Check if the ~/.debug directory is present, if not, create it.

Also maybe use:

   Informative output
       --checkpoint[=N]
              Display progress messages every Nth record (default 10).

       --checkpoint-action=ACTION
              Run ACTION on each checkpoint.

with 'tar' to show some progress in decompressing the tarball.

- Arnaldo