From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
Cc: lee@kernel.org, linux-kernel@vger.kernel.org, hdegoede@redhat.com
Subject: Re: [PATCH v1 2/2] mfd: intel-lpss: Introduce QUIRK_CLOCK_DIVIDER_UNITY for XPS 9530
Date: Wed, 20 Dec 2023 17:12:40 +0200 [thread overview]
Message-ID: <ZYMEaBWwtGEyaNVL@smile.fi.intel.com> (raw)
In-Reply-To: <20231220073148.19402-3-alex.vinarskis@gmail.com>
On Wed, Dec 20, 2023 at 08:31:48AM +0100, Aleksandrs Vinarskis wrote:
> Some devices (eg. Dell XPS 9530, 2023) due to a firmware bug have a
> misconfigured clock divider, which should've been 1:1. This introduces
> quirk which conditionally re-configures the clock divider to 1:1.
(Btw, do you use --histogram when preparing patches? Use it in v2.)
...
> + }, { /* Dell XPS 9530 (2023) */
> + PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x51fb, 0x1028, 0x0beb),
> + .driver_data = (kernel_ulong_t)&quirk_skip_clock_divider,
> },
Should be
}, { /* Dell XPS 9530 (2023) */
PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x51fb, 0x1028, 0x0beb),
.driver_data = QUIRK_CLOCK_DIVIDER_UNITY,
},
...
> #define QUIRK_IGNORE_RESOURCE_CONFLICTS BIT(0)
> +#define QUIRK_CLOCK_DIVIDER_UNITY BIT(1)
Each quirk should be documented, see, for example,
https://elixir.bootlin.com/linux/latest/source/include/linux/gpio/consumer.h#L593
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-20 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 7:31 [PATCH v1 0/2] Fix LPSS clock divider for XPS 9530 Aleksandrs Vinarskis
2023-12-20 7:31 ` [PATCH v1 1/2] mfd: intel-lpss: Switch to generalized quirk table Aleksandrs Vinarskis
2023-12-20 15:08 ` Andy Shevchenko
2023-12-20 7:31 ` [PATCH v1 2/2] mfd: intel-lpss: Introduce QUIRK_CLOCK_DIVIDER_UNITY for XPS 9530 Aleksandrs Vinarskis
2023-12-20 15:12 ` Andy Shevchenko [this message]
2023-12-20 20:56 ` [PATCH v2 0/2] Fix LPSS clock divider " Aleksandrs Vinarskis
2023-12-20 20:56 ` [PATCH v2 1/2] mfd: intel-lpss: Switch to generalized quirk table Aleksandrs Vinarskis
2023-12-21 12:41 ` Andy Shevchenko
2023-12-21 12:46 ` Andy Shevchenko
2023-12-20 20:56 ` [PATCH v2 2/2] mfd: intel-lpss: Introduce QUIRK_CLOCK_DIVIDER_UNITY for XPS 9530 Aleksandrs Vinarskis
2023-12-21 12:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYMEaBWwtGEyaNVL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alex.vinarskis@gmail.com \
--cc=hdegoede@redhat.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox