From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC06476095; Thu, 21 Dec 2023 22:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qYnlUlF9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5jl+j8VoAJ0TH+y6nII30+cXSo3AkwWFgfdB0n28bjc=; b=qYnlUlF9BEORe4ao7JNQ8ooRm/ BYv+/cuY5/1MvnSoiroxHyPmtjI2F7ExzVRIYu7ww7EjxClT8aX+Qj5WDVaNblw1bwNrPMW/FaO1M 24Q5U4h9VsQIvZ4BXfRmFkdI3DfRBzbjqAUf98ykniHwcdaVE1/8E4j0jG/I0qKPBYoiN15aQVdfv tAQcX1rd4eVHcX6e8jpR5gY+eUPFdYG8yiVuIKXfqxgXCVQCmYNSjxSJQKkyamoh36G9LxKrMykZx AUaftO04oM+7cMFrhxxVsvjhGEOFFOMFEJ5EAjVbU/s1/NfjDBMcUEFTCmLnybtiMPPQl2W+lZzSj Zk0R0WWA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGRIO-006J3l-2k; Thu, 21 Dec 2023 22:13:36 +0000 Date: Thu, 21 Dec 2023 22:13:36 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: Andrew Morton , Oliver Sang , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [mm] bbcbf2a3f0: kernel_BUG_at_mm/memory.c Message-ID: References: <202312192319.fa8f5709-oliver.sang@intel.com> <20231220141135.cb4241442b657104f0aeae34@linux-foundation.org> <20231221135833.92b8b2a97b28ad0545977f6c@linux-foundation.org> <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com> On Thu, Dec 21, 2023 at 11:07:21PM +0100, David Hildenbrand wrote: > Subject: [PATCH] Fixup: mm: convert ksm_might_need_to_copy() to work on folios > > We must only adjust the page if the folio changed. Otherwise, if we > had a large folio in the swapcache and the folio didn't change, we'd > suddenly change the page to-be-mapped. Heh, I was expecting you to be done for the day ;-)