From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-btrfs@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH 1/2] lib/strtox: introduce kstrtoull_suffix() helper
Date: Thu, 21 Dec 2023 22:55:20 +0200 [thread overview]
Message-ID: <ZYSmOCcqbBbbFx-s@smile.fi.intel.com> (raw)
In-Reply-To: <cf3808eb-0c8f-4a51-b2b4-14eb33b88992@gmx.com>
On Fri, Dec 22, 2023 at 07:07:31AM +1030, Qu Wenruo wrote:
> On 2023/12/21 22:30, Andy Shevchenko wrote:
...
> Then what about going the following path for the whole memparse() rabbit
> hole?
>
> - Mark the old memparse() deprecated
> - Add a new function memparse_safe() (or rename the older one to
> __memparse, and let the new one to be named memparse()?)
> - Add unit test for the new memparse_safe() or whatever the name is
> - Try my best to migrate as many call sites as possible
> Only the two btrfs ones I'm 100% confident for now
>
> Would that be a sounding plan?
As long as it does not break any ABI (like kernel command line parsing),
sounds good to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-21 20:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 14:24 [PATCH 1/2] lib/strtox: introduce kstrtoull_suffix() helper Andy Shevchenko
2023-12-20 20:38 ` Qu Wenruo
2023-12-21 12:00 ` Andy Shevchenko
2023-12-21 20:37 ` Qu Wenruo
2023-12-21 20:55 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-20 9:54 Alexey Dobriyan
2023-12-20 10:01 ` Qu Wenruo
2023-12-20 14:16 ` Andy Shevchenko
2023-12-18 13:44 Andy Shevchenko
[not found] <cover.1702628925.git.wqu@suse.com>
2023-12-15 8:39 ` Qu Wenruo
2023-12-18 12:59 ` David Disseldorp
2023-12-18 19:52 ` Qu Wenruo
2023-12-19 3:17 ` David Disseldorp
2023-12-19 16:42 ` David Laight
2023-12-19 21:17 ` Qu Wenruo
2023-12-20 8:31 ` David Laight
2023-12-20 9:32 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYSmOCcqbBbbFx-s@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox