Re: [PATCH v3 4/4] ARM: dts: imx6sl-tolino-shine2hd: fix touchscreen rotation

Dmitry Torokhov
2023-12-24T08:47:13Z

On Sat, Dec 23, 2023 at 11:12:13PM +0100, Andreas Kemnade wrote:
> The display is in landscape orientation, but the touchscreen is in portrait
> orientation. Specify that properly in the devicetree.

This needs to be merged by the board maintainer.

>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts
> index 815119c12bd48..5636fb3661e8a 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts
> @@ -141,8 +141,10 @@ zforce: touchscreen@50 {
> interrupts = <6 IRQ_TYPE_EDGE_FALLING>;

Could you please prepare a patch changing this to IRQ_TYPE_LEVEL_LOW to
match what the driver is actually doing?

> vdd-supply = <&ldo1_reg>;
> reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> - x-size = <1072>;
> - y-size = <1448>;
> + touchscreen-size-x = <1072>;
> + touchscreen-size-y = <1448>;
> + touchscreen-swapped-x-y;
> + touchscreen-inverted-x;
> };
>
> /* TODO: TPS65185 PMIC for E Ink at 0x68 */
> --
> 2.39.2
>

Thanks.

--
Dmitry