The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>,
	attreyee-muk <tintinm2017@gmail.com>,
	jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
	pmladek@suse.com, joe.lawrence@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	live-patching@vger.kernel.org
Subject: Re: [PATCH] Documentation/livepatch: Update terminology in livepatch
Date: Tue, 26 Dec 2023 11:51:53 +0700	[thread overview]
Message-ID: <ZYpb6Woh45ZnEvCP@archie.me> (raw)
In-Reply-To: <87o7eg607d.fsf@meer.lwn.net>

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Sat, Dec 23, 2023 at 03:08:54PM -0700, Jonathan Corbet wrote:
> attreyee-muk <tintinm2017@gmail.com> writes:
> 
> > Update the sentence in livepatch.rst to: "Functions are there for a reason. Take some input parameters, acquire or release locks, read, process, and write some data in a defined way."
> >
> > Signed-off-by: Attreyee Mukherjee <tintinm2017@gmail.com>
> > ---
> >  Documentation/livepatch/livepatch.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> So this is a classic example of saying what you have done, but not why.
> What makes this a change that we want?

I think what he intended was "The word 'get' is not the correct antonym to
'release' in the context of locking. Replace it with 'acquire'".

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-12-26  4:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-23 20:58 [PATCH] Documentation/livepatch: Update terminology in livepatch attreyee-muk
2023-12-23 22:08 ` Jonathan Corbet
2023-12-26  4:51   ` Bagas Sanjaya [this message]
2024-01-10 17:56     ` Attreyee M
     [not found]     ` <CAJjsb4reD_TVWRFonp90xXD4Ye2OOfOd894PzmfMKaP3qFkbYg@mail.gmail.com>
2024-01-10 18:15       ` Jonathan Corbet
2024-01-10 18:20         ` Attreyee M
2024-01-10 18:51         ` Marcos Paulo de Souza
2024-01-11 15:17           ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYpb6Woh45ZnEvCP@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    --cc=tintinm2017@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox