From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, conor+dt@kernel.org,
krzysztof.kozlowski@linaro.org, robh+dt@kernel.org,
kevin-lu@ti.com, baojun.xu@ti.com, devicetree@vger.kernel.org,
lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de,
peeyush@ti.com, navada@ti.com
Subject: Re: [PATCH v3 4/5] ASoC: tas2781: Add tas2563 into driver
Date: Wed, 27 Dec 2023 18:51:45 +0200 [thread overview]
Message-ID: <ZYxWIcnfNWyTJ9Tz@smile.fi.intel.com> (raw)
In-Reply-To: <20231225053932.1138-4-shenghao-ding@ti.com>
On Mon, Dec 25, 2023 at 01:39:30PM +0800, Shenghao Ding wrote:
> Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only
> work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode
> for tas2563, it has been moved to tas2781 driver. As to the hardware part,
> such as register setting and DSP firmware, all these are stored in the
> binary firmware. What tas2781 drivder dooes is to parse the firmware and
> download them to the tas2781 or tas2563, then power on tas2781 or tas2563.
> So, tas2781 driver can be resued as tas2563 driver. Only attention will be
> paid to downloading corresponding firmware.
> -// The TAS2781 driver implements a flexible and configurable
> +// The TAS2781/TAS2563 driver implements a flexible and configurable
> -// TAS2781 chips.
> +// TAS2781/TAS2563 chips.
> static const struct i2c_device_id tasdevice_id[] = {
> { "tas2781", TAS2781 },
> + { "tas2563", TAS2563 },
> {}
> };
> static const struct of_device_id tasdevice_of_match[] = {
> { .compatible = "ti,tas2781" },
> + { .compatible = "ti,tas2563" },
> {},
> };
In all cases make the lists ordered by a chip model.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-27 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 5:39 [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Shenghao Ding
2023-12-25 5:39 ` [PATCH v3 2/5] ASoC: tas2562: move tas2563 from tas2562 driver to tas2781 driver Shenghao Ding
2023-12-27 16:50 ` Andy Shevchenko
2023-12-25 5:39 ` [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for DSP mode Shenghao Ding
2023-12-25 5:39 ` [PATCH v3 4/5] ASoC: tas2781: Add tas2563 into driver Shenghao Ding
2023-12-27 16:51 ` Andy Shevchenko [this message]
2023-12-25 5:39 ` [PATCH v3 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to enable DSP mode Shenghao Ding
2023-12-25 13:18 ` Krzysztof Kozlowski
2023-12-27 6:58 ` [EXTERNAL] " Ding, Shenghao
2023-12-27 11:02 ` Krzysztof Kozlowski
2023-12-25 13:12 ` [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYxWIcnfNWyTJ9Tz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox