Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()

Rob Herring
2024-01-02T16:01:06Z

On Wed, Dec 27, 2023 at 11:21:14AM -0700, Mark Hasemeyer wrote:
> >
> > > + u32 irq_flags;
> > > const char *name = NULL;
> >
> > Don't know if OF style requires reversed xmas tree order. If so, this should be
> >
> > const char *name = NULL;
> > u32 irq_flags;
> >
>
> I see both methods used. For example, of_irq_init() uses normal xmas
> tree order. I'll leave it unless Rob says otherwise.
> It is Christmas time, so I do want to honor the Christmas trees appropriately!

DT requires sideways Christmas tree because we're special. You'll have
to add a 3rd variable. ;)

Rob