Re: [PATCH v3 01/24] resource: Add DEFINE_RES_*_NAMED_FLAGS macro

Andy Shevchenko
2023-12-27T17:05:57Z

On Tue, Dec 26, 2023 at 12:21:05PM -0700, Mark Hasemeyer wrote:
> In some cases, it would be nice to instantiate a struct resource with
> custom flags. For example, creating an IRQ resource with a flag that
> marks the interrupt as wake capable.
>
> Add a set of macros to provide custom flag arguments.

> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Was it @intel.com? Please, use @linux.intel.com anyway.

> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>

Tag block must _not_ have any blank line(s).

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

While we will have user only for IRQ case, the rest are added for symmetry's
sake, I think it's okay and we might even have more (existing) users to convert
to new macros (at least it rings a bell to me for a few places).

--
With Best Regards,
Andy Shevchenko