Re: [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource

Andy Shevchenko
2023-12-27T17:24:42Z

On Tue, Dec 26, 2023 at 12:21:25PM -0700, Mark Hasemeyer wrote:
> The underlying ACPI and OF subsystems provide their own APIs which
> provide IRQ information as a struct resource. This allows callers to get
> more information about the IRQ by looking at the resource flags. For
> example, whether or not an IRQ is wake capable.

...

> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>

No blank line.

...

A side note: in all files where you use ioport.h check if you actually included it.

...

> -#include <linux/types.h>
> -#include <linux/list.h>
> #include <linux/bits.h>
> #include <linux/err.h>
> +#include <linux/ioport.h>
> +#include <linux/list.h>
> +#include <linux/types.h>

Fine, but no. This file is still not using the iopoll.h.
See the forward declarations below? It should be there.

> struct fwnode_operations;
> struct device;

...

> --- a/include/linux/property.h
> +++ b/include/linux/property.h

Same comment(s) here.

--
With Best Regards,
Andy Shevchenko