From: Andi Kleen <ak@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mtrr: Check if fixed MTRRs exist before saving them
Date: Tue, 9 Jan 2024 20:24:09 -0800 [thread overview]
Message-ID: <ZZ4b6aq6s_GbpbcN@tassilo> (raw)
In-Reply-To: <87plyajphp.ffs@tglx>
On Tue, Jan 09, 2024 at 08:06:26PM +0100, Thomas Gleixner wrote:
> On Fri, Jan 05 2024 at 08:37, Andi Kleen wrote:
> > This one place forgot to check the fixed capability.
>
> What's the consequence of that missing chec
You get a WARN_ON for a WRMSR failing if you don't have the MSR.
> and shouldn't this have a Fixes tag?
It's more an ancient bug back dating back to my tenure in 2007, but here it is:
Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before")
-Andi
next prev parent reply other threads:[~2024-01-10 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 16:37 [PATCH] x86/mtrr: Check if fixed MTRRs exist before saving them Andi Kleen
2024-01-09 19:06 ` Thomas Gleixner
2024-01-10 4:24 ` Andi Kleen [this message]
2024-01-10 14:20 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ4b6aq6s_GbpbcN@tassilo \
--to=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox