From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 545DC566B for ; Tue, 2 Jan 2024 08:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JSz+CKa1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704184886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9deNeZJNUQtUZJSaXTSS5TWxhTaiDOSx9nA+IbokTkw=; b=JSz+CKa1SMpYiK2DT1syCeZwpHGJiGYt/5r9WN9HVTPWAGgpyUC26vaU51SIuAijIDN39F hhRLmTy0q2AFstmJUAX4GneZGtkIFBVlQo69lE12OiK+aEBgeeuK8wd5my7XyjDx3YUoFw /EDOSLMWWw7SEgSEGFZWyXddpdY4tXU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-v1563Ci_PTOWBkrNbLVl9Q-1; Tue, 02 Jan 2024 03:41:23 -0500 X-MC-Unique: v1563Ci_PTOWBkrNbLVl9Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 42B8A80BEC1; Tue, 2 Jan 2024 08:41:22 +0000 (UTC) Received: from localhost (unknown [10.72.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 796031121306; Tue, 2 Jan 2024 08:41:20 +0000 (UTC) Date: Tue, 2 Jan 2024 16:41:17 +0800 From: Baoquan He To: Yuntao Wang Cc: Andrew Morton , bp@alien8.de, dave.hansen@linux.intel.com, dyoung@redhat.com, eric.devolder@oracle.com, hbathini@linux.ibm.com, hpa@zytor.com, kexec@lists.infradead.org, lijiang@redhat.com, linux-kernel@vger.kernel.org, mingo@redhat.com, seanjc@google.com, sourabhjain@linux.ibm.com, tglx@linutronix.de, tiwai@suse.de, vgoyal@redhat.com, x86@kernel.org Subject: Re: [PATCH 3/3] crash_core: fix and simplify the logic of crash_exclude_mem_range() Message-ID: References: <20231216015410.188924-1-ytcoode@gmail.com> <20231229121052.cac37914c7a051b829fcf933@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Hi Yuntao, On 12/30/23 at 06:16pm, Baoquan He wrote: > On 12/29/23 at 12:10pm, Andrew Morton wrote: > > On Sat, 16 Dec 2023 11:31:04 +0800 Baoquan He wrote: > > > > > > > Imagine we have a crashkernel region 256M reserved under 4G, say [2G, 2G+256M]. > > > > > Then after excluding the 256M from a region, it should stop. But now, this patch > > > > > will make it continue scanning. Not sure if it's all in my mind. > > > > > > > > Hi Baoquan, > > > > > > > > Thank you for such a detailed reply. Now I finally understand why the code is > > > > written this way. > > > > > > > > However, if we can guarantee its correctness, wouldn't it be better to use the > > > > generic region removing logic? At least it is more concise and clear, and other > > > > people reading this code for the first time wouldn't get confused like me. > > > > > > > > As for your concern about the while loop, I think it wouldn't affect performance > > > > much because the total number of loops is small. > > > > > > Well, see below kexec-tools commit, you wouldn't say that. And when you > > > understand the code, you will feel a little uncomfortable about the > > > sustaining useless scanning. At least, we should stop scanning after > > > needed exluding is done. > > > > > > Or, we may need add a generic region removing function so that it > > > can be shared, e.g e820 memory region removing, memblock region removing. > > > Otherwise, I can't see why a specific region excluding need a generic > > > region removing function. > > > > So where do we now stand on this patchset? > > The patch 1 and 2 are good clean up. The patch 3 plus below one, the > entire is a good code improvement patch. > > [PATCH] crash_core: optimize crash_exclude_mem_range() > https://lore.kernel.org/all/20231219163418.108591-1-ytcoode@gmail.com/T/#u Can you repost this patchset with some updating, e.g adding ack in patch 1 and 2, and squash below patch into patch 3? This will be easier for patch merging. [PATCH] crash_core: optimize crash_exclude_mem_range() https://lore.kernel.org/all/20231219163418.108591-1-ytcoode@gmail.com/T/#u And, you may need to drop below patchset since patch 2 conflicts with this patchset, and patch 1 is conflicting with fuqiang's patch. [PATCH 0/2] crash: fix potential cmem->ranges array overflow Thanks Baoquan