From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A033ECA64 for ; Tue, 2 Jan 2024 09:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XEX95bv8" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-336897b6bd6so9083677f8f.2 for ; Tue, 02 Jan 2024 01:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704188997; x=1704793797; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=czuPNSsZEEViwXKMxRjI0Bf2/iQSweSghdx0XFLXISw=; b=XEX95bv87Gu9S2r9EfXB+rH1lCQm9dXBC4b0UTgCTu4TZ9Rro5kq+ETMZ0Cb7t5oAT E9pTQzDBMoJNA/U+JuPwCsT75gT6DUQFrZlFVLkQSInfU3gQz2bBekhI1RC53VOOLScL 89TIU3IT6CuGhGyI37XwSt/pOKO2RJ3TNHDalrHFa+nOrwAwSsKHQeTAOR5XpeKzBIex 8bvv00MEHyLW1K2QGGzBWINhK3nPfU5fL1mMWQOnxpj8JJURcZXlbcIIDwUTc3UBz9c+ 2bDD6kR83rG6yRy7e6QIgjHSF9DuCz3MJlm4/u7Q7hyWIHac0zoNJzivfy+lEjxKa9KV /AdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704188997; x=1704793797; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=czuPNSsZEEViwXKMxRjI0Bf2/iQSweSghdx0XFLXISw=; b=NJDID4sk5rp45a+y99J2B8D9MeTS/s9jOUDHr32oayIANCS89RWVztXxrj2R2GNTB/ DCYTQVpR7m2+bNoQlGmgtnYzdgBS4P7UYjxRslSg1SCdSjXJwtg4NkSZN/ZO1XFqtUaI SQqWAV0u5JpQwoW0v1wcO2p0QdQYXu59k+r69rlbUo5ZaBVsbqGqH3aQz0GibGVWQS50 dkrA2NcxOV/xnHqpH4tzYLCePeqD2bEr3RgjsxZU42ZB0+p1ahZ1i8B5f7gfNHCPgPAZ bt/ALfGu1J9Es+LXb+5Qtj6ZMlFDLlumR+KDirKDbTfvDgFzQ8g0Ibt2uGmndeWsI7Ph 15eA== X-Gm-Message-State: AOJu0YyGZvfkBU0XBKY2CH4+511sg69AW/9Lm266UHYTxkDNW+qyT0H7 eoNHO7bUDg1bmELLGAK8K04= X-Google-Smtp-Source: AGHT+IFyL1kGzmCf7lxa2xG8+lAeF0tqLdKViQzr82/M4+rH5ogcX/7IRHOaL8FuAajxdwVnvWcTNw== X-Received: by 2002:a5d:598b:0:b0:336:ef13:301c with SMTP id n11-20020a5d598b000000b00336ef13301cmr6579876wri.111.1704188996642; Tue, 02 Jan 2024 01:49:56 -0800 (PST) Received: from gmail.com (195-38-113-95.pool.digikabel.hu. [195.38.113.95]) by smtp.gmail.com with ESMTPSA id u17-20020a5d4351000000b00336f05840c4sm15268416wrr.100.2024.01.02.01.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 01:49:56 -0800 (PST) Sender: Ingo Molnar Date: Tue, 2 Jan 2024 10:49:54 +0100 From: Ingo Molnar To: David Laight Cc: "'linux-kernel@vger.kernel.org'" , "'peterz@infradead.org'" , "'longman@redhat.com'" , "'mingo@redhat.com'" , "'will@kernel.org'" , "'boqun.feng@gmail.com'" , 'Linus Torvalds' , "'virtualization@lists.linux-foundation.org'" , 'Zeng Heng' Subject: Re: [PATCH next v2 1/5] locking/osq_lock: Defer clearing node->locked until the slow osq_lock() path. Message-ID: References: <2b4e8a5816a742d2bd23fdbaa8498e80@AcuMS.aculab.com> <714ca2e587cf4cd485ae04e5afb8d5bb@AcuMS.aculab.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <714ca2e587cf4cd485ae04e5afb8d5bb@AcuMS.aculab.com> * David Laight wrote: > Since node->locked cannot be set before the assignment to prev->next > it is save to clear it in the slow path. s/save /safe Thanks, Ingo