From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
yuiko.oshino@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH net] net: phy: micrel: populate .soft_reset for KSZ9131
Date: Fri, 5 Jan 2024 09:43:22 +0000 [thread overview]
Message-ID: <ZZfPOky2p/ZJMKCQ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240105085242.1471050-1-claudiu.beznea.uj@bp.renesas.com>
On Fri, Jan 05, 2024 at 10:52:42AM +0200, Claudiu wrote:
> The order of PHY-related operations in ravb_open() is as follows:
> ravb_open() ->
> ravb_phy_start() ->
> ravb_phy_init() ->
> of_phy_connect() ->
> phy_connect_direct() ->
> phy_attach_direct() ->
> phy_init_hw() ->
> phydev->drv->soft_reset()
> phydev->drv->config_init()
> phydev->drv->config_intr()
> phy_resume()
> kszphy_resume()
>
> The order of PHY-related operations in ravb_close is as follows:
> ravb_close() ->
> phy_stop() ->
> phy_suspend() ->
> kszphy_suspend() ->
> genphy_suspend()
> // set BMCR_PDOWN bit in MII_BMCR
Andrew,
This looks wrong to me - shouldn't we be resuming the PHY before
attempting to configure it?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-01-05 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 8:52 [PATCH net] net: phy: micrel: populate .soft_reset for KSZ9131 Claudiu
2024-01-05 9:43 ` Russell King (Oracle) [this message]
2024-01-05 14:36 ` Andrew Lunn
2024-01-05 15:53 ` Maxime Chevallier
2024-01-10 13:20 ` claudiu beznea
2024-01-12 1:30 ` Andrew Lunn
2024-01-05 9:43 ` Maxime Chevallier
2024-01-12 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZfPOky2p/ZJMKCQ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox